Review main Merged

15980[TASK] Add possibility for a custom TCA TreeProvider

Georg Ringer CR +2 V +2 Normal +173 −34 updated 06/03/13, 20:49

Commit message

Currently the tca tree uses its own DataProvider
which makes sense but this is not extendable.
Adding 3 additional lines would make it possible
to use a custom provider.

Needed e.g. in EXT:news to be able to render a tca tree
with some BE user/-group restrictions ...

Review

  • Code review CR +2
    • Georg Ringer +2
    • Helmut Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +1

Issues 1

Files 2

Review log 22

  1. Helmut Hummel commented on patch set 1 11/05/12, 06:34

    (1 inline comment) +1 for the idea

    TreeDataProviderFactory.php:53

    If you put the above line in an else part of the check if a dataProvider is configured, I'm fine with this change going into 6.0
  2. Helmut Hummel commented on patch set 1 11/05/12, 06:34

    not sure if this can go in TYPO3 versions below 6.0, I tend to say no.
  3. Helmut Hummel uploaded patch set 2 11/05/12, 06:34

  4. Helmut Hummel uploaded patch set 3 11/05/12, 06:34

  5. Helmut Hummel commented on patch set 4 11/05/12, 06:34

    Verified; Looks good to me, but someone else must approve
  6. Helmut Hummel uploaded patch set 4 11/05/12, 06:34

  7. Georg Ringer commented on patch set 4 11/05/12, 06:34

    Verified; Looks good to me, but someone else must approve
  8. Helmut Hummel commented on patch set 5 11/05/12, 06:34

    I would prefer that you didn't submit this accidental patchset 5, please push patchset 4 again
  9. Helmut Hummel uploaded patch set 6 11/05/12, 06:34

  10. Helmut Hummel uploaded patch set 7 11/05/12, 06:34

  11. Helmut Hummel commented on patch set 7 11/05/12, 06:34

    Verified; Looks good to me, but someone else must approve
  12. Georg Ringer uploaded patch set 5 11/05/12, 06:34

  13. Georg Ringer commented on patch set 7 V 0 11/05/12, 06:34

    by team member; Looks good to me, approved
  14. Georg Ringer commented on patch set 7 11/05/12, 06:34

    can be get that in? ;)
  15. Mr. Jenkins commented on patch set 1 11/05/12, 06:34

  16. Mr. Jenkins commented on patch set 2 11/05/12, 06:34

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6422/ : FAILURE
  17. Mr. Jenkins commented on patch set 3 11/05/12, 06:34

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6423/ : FAILURE
  18. Mr. Jenkins commented on patch set 4 11/05/12, 06:34

  19. Mr. Jenkins commented on patch set 5 11/05/12, 06:34

  20. Mr. Jenkins commented on patch set 6 11/05/12, 06:34

  21. Mr. Jenkins commented on patch set 7 11/05/12, 06:34

  22. Georg Ringer merged patch set 7 11/05/12, 06:34