16018[TASK] Optimize compatibilty class loader
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Helmut Hummel +1
Issues 1
Files 5
- typo3/sysext/core/Classes/Compatibility/CompatbilityClassLoaderPhpBelow50307.php2+67 −20
- typo3/sysext/core/Classes/Core/ClassLoader.php+5 −1
- typo3/sysext/core/Tests/Unit/Compatibility/CompatbilityClassLoaderPhpBelow50307Test.phpnew+284 −0
- typo3/sysext/core/Tests/Unit/Core/Fixtures/LegacyClassFixture.phpdeleted+0 −74
- typo3/sysext/core/Tests/Unit/Core/ClassLoaderTest.php+0 −17
Review log 27
Show 2 earlier messages
-
Helmut Hummel commented on patch set 3 11/19/12, 19:08
I would prefer that you didn't submit this Improved but tests still incomplete -
Helmut Hummel uploaded patch set 4 11/19/12, 19:08
-
Helmut Hummel uploaded patch set 5 11/19/12, 19:08
-
Helmut Hummel uploaded patch set 6 11/19/12, 19:08
-
Helmut Hummel commented on patch set 7 11/19/12, 19:08
(1 inline comment) -
Helmut Hummel uploaded patch set 7 11/19/12, 19:08
-
Christian Kuhn commented on patch set 7 V 0 11/19/12, 19:08
seems to work for me, still i'd like to have a deeper look on the code.CompatbilityClassLoaderPhpBelow50307.php:75substr(,0,3) and user_ prefix won't work. -
Christian Kuhn commented on patch set 7 1 comment 11/19/12, 19:08
I would prefer that you didn't submit this -1 on reading, working on it. -
Helmut Hummel commented on patch set 8 11/19/12, 19:08
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 8 11/19/12, 19:08
-
Christian Kuhn commented on patch set 8 11/19/12, 19:08
Modifications: * reformatted some tests (those that don't do too much whitespace foo in declared methods) * added test for the 'rewrite allowed' prefixes, and extracted one method meanwhile * Added prefix ux_, Ux_ and User_ -
Christian Kuhn commented on patch set 8 11/19/12, 19:08
Verified; Looks good to me, but someone else must approve -
Thomas Maroschik commented on patch set 6 11/19/12, 19:08
Looks good to me, but someone else must approve -
Thomas Maroschik commented on patch set 7 11/19/12, 19:08
Looks good to me, but someone else must approve Thanks for the warning comment. -
Mattias Nilsson commented on patch set 7 11/19/12, 19:08
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6448/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6449/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/19/12, 19:08
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6468/ : FAILURE -
Mr. Jenkins commented on patch set 4 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6677/ : SUCCESS -
Mr. Jenkins commented on patch set 5 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6678/ : SUCCESS -
Mr. Jenkins commented on patch set 6 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6679/ : SUCCESS -
Mr. Jenkins commented on patch set 7 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6680/ : SUCCESS -
Mr. Jenkins commented on patch set 8 11/19/12, 19:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6692/ : SUCCESS -
Christian Kuhn commented on patch set 8 V 0 11/19/12, 19:08
by team member; Looks good to me, approved tested again. i'm pretty sure this works as expected ... merged for now. -
Christian Kuhn merged patch set 8 11/19/12, 19:08