Review main Merged

16018[TASK] Optimize compatibilty class loader

Helmut Hummel CR +2 V +2 Hard +356 −112 updated 06/03/13, 20:49

Commit message

Do not save rewritten code in compatibility class loader
if no replacements have been found but require the
original class instead.
Additionally do not touch classes that do not start
with 'tx_' or other known TYPO3 specific prefixes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +1

Issues 1

Files 5

Review log 27

Show 2 earlier messages
  1. Helmut Hummel uploaded patch set 2 11/19/12, 19:08

  2. Helmut Hummel uploaded patch set 3 11/19/12, 19:08

  1. Helmut Hummel commented on patch set 3 11/19/12, 19:08

    I would prefer that you didn't submit this Improved but tests still incomplete
  2. Helmut Hummel uploaded patch set 4 11/19/12, 19:08

  3. Helmut Hummel uploaded patch set 5 11/19/12, 19:08

  4. Helmut Hummel uploaded patch set 6 11/19/12, 19:08

  5. Helmut Hummel commented on patch set 7 11/19/12, 19:08

    (1 inline comment)
  6. Helmut Hummel uploaded patch set 7 11/19/12, 19:08

  7. Christian Kuhn commented on patch set 7 V 0 11/19/12, 19:08

    seems to work for me, still i'd like to have a deeper look on the code.

    CompatbilityClassLoaderPhpBelow50307.php:75

    substr(,0,3) and user_ prefix won't work.
  8. Christian Kuhn commented on patch set 7 1 comment 11/19/12, 19:08

    I would prefer that you didn't submit this -1 on reading, working on it.
  9. Helmut Hummel commented on patch set 8 11/19/12, 19:08

    Verified; Looks good to me, but someone else must approve
  10. Christian Kuhn uploaded patch set 8 11/19/12, 19:08

  11. Christian Kuhn commented on patch set 8 11/19/12, 19:08

    Modifications: * reformatted some tests (those that don't do too much whitespace foo in declared methods) * added test for the 'rewrite allowed' prefixes, and extracted one method meanwhile * Added prefix ux_, Ux_ and User_
  12. Christian Kuhn commented on patch set 8 11/19/12, 19:08

    Verified; Looks good to me, but someone else must approve
  13. Thomas Maroschik commented on patch set 6 11/19/12, 19:08

    Looks good to me, but someone else must approve
  14. Thomas Maroschik commented on patch set 7 11/19/12, 19:08

    Looks good to me, but someone else must approve Thanks for the warning comment.
  15. Mattias Nilsson commented on patch set 7 11/19/12, 19:08

    Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 11/19/12, 19:08

  17. Mr. Jenkins commented on patch set 2 11/19/12, 19:08

  18. Mr. Jenkins commented on patch set 3 11/19/12, 19:08

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6468/ : FAILURE
  19. Mr. Jenkins commented on patch set 4 11/19/12, 19:08

  20. Mr. Jenkins commented on patch set 5 11/19/12, 19:08

  21. Mr. Jenkins commented on patch set 6 11/19/12, 19:08

  22. Mr. Jenkins commented on patch set 7 11/19/12, 19:08

  23. Mr. Jenkins commented on patch set 8 11/19/12, 19:08

  24. Christian Kuhn commented on patch set 8 V 0 11/19/12, 19:08

    by team member; Looks good to me, approved tested again. i'm pretty sure this works as expected ... merged for now.
  25. Christian Kuhn merged patch set 8 11/19/12, 19:08