Review main Merged

16098[BUGFIX] FILES ContentObject ignores language handling

Steffen Ritter CR +2 V +2 Easy +6 −2 updated 06/03/13, 20:49

Commit message

The FILES TypoScript ContentObject, which is responsible
for rendering content element type "uploads" does not take
care of languages and pages_language_overlay table.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 9

  1. Helmut Hummel commented on patch set 1 V 0 11/01/12, 17:06

    by team member; Looks good to me, approved
    Should be Resolved:
  2. Helmut Hummel commented on patch set 1 11/01/12, 17:06

    (1 inline comment)
  3. Helmut Hummel commented on patch set 1 11/01/12, 17:06

    I would prefer that you didn't submit this
  4. Helmut Hummel uploaded patch set 2 11/01/12, 17:06

  5. Mr. Jenkins commented on patch set 1 11/01/12, 17:06

  6. Mr. Jenkins commented on patch set 2 11/01/12, 17:06

  7. Dominik Mathern commented on patch set 1 11/01/12, 17:06

    Verified; Looks good to me, but someone else must approve
  8. Helmut Hummel commented on patch set 2 V 0 11/01/12, 17:06

    by team member; Looks good to me, approved
  9. Helmut Hummel merged patch set 2 11/01/12, 17:06