16104[BUGFIX] Check if List module TCA has empty keys
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 16
-
Markus Klein commented on patch set 1 12/06/12, 13:55
(1 inline comment)AbstractDatabaseRecordList.php:392Please check $value instead of $GLOBALS['TCA'][$tableName]AbstractDatabaseRecordList.php:392Sorry, obviously my comment was not precise enough. I ment is_array($value). I'll push a new version -
Markus Klein commented on patch set 2 12/06/12, 13:55
(1 inline comment) Please don't forget to set the Topic when pushing. -
Markus Klein uploaded patch set 3 12/06/12, 13:55
-
Markus Klein commented on patch set 3 12/06/12, 13:55
I restructured the whole if and removed $value, as it was unused anyway. -
Christian Kuhn commented on patch set 3 12/06/12, 13:55
Thanks for the patch. At first I already stumbled upon the commit header, could this please be a bit more precise (blank screen usually is a fatal error) ... -
Mattias Nilsson uploaded patch set 2 12/06/12, 13:55
-
Mattias Nilsson commented on patch set 3 12/06/12, 13:55
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 4 12/06/12, 13:55
I fully agree with Olly. As stated in the forge ticket, IMO something is wrong with the installation. -
Oliver Hader commented on patch set 4 12/06/12, 13:55
I would prefer that you didn't submit this TCA should not contain empty values - if so, this has to be checked at another layer - if it fails here, it might fail in other modules as well. Thus, rewriting every module does not sound optimal, instead let's try to sanitize TCA in the bootstrap mechanisms... -
Oliver Hader commented on patch set 4 12/06/12, 13:55
Releases is 6.0 only - doesn't that occur in older branches as well? -
Mattias Nilsson uploaded patch set 4 12/06/12, 13:55
-
Mr. Jenkins commented on patch set 1 12/06/12, 13:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6495/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/06/12, 13:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6508/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/06/12, 13:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6510/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/06/12, 13:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6519/ : SUCCESS -
Mattias Nilsson commented on patch set 4 12/06/12, 13:55
Abandoned