Review main Abandoned

16104[BUGFIX] Check if List module TCA has empty keys

Mattias Nilsson CR 0 V 0 Normal +49 −44 updated 06/03/13, 20:49

Commit message

When clicking on the List module in the backend the screen goes blank.
This is due to the fact that the TCA has empty (invalid) keys.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 16

  1. Markus Klein commented on patch set 1 12/06/12, 13:55

    (1 inline comment)

    AbstractDatabaseRecordList.php:392

    Please check $value instead of $GLOBALS['TCA'][$tableName]

    AbstractDatabaseRecordList.php:392

    Sorry, obviously my comment was not precise enough. I ment is_array($value). I'll push a new version
  2. Markus Klein commented on patch set 2 12/06/12, 13:55

    (1 inline comment) Please don't forget to set the Topic when pushing.
  3. Markus Klein uploaded patch set 3 12/06/12, 13:55

  4. Markus Klein commented on patch set 3 12/06/12, 13:55

    I restructured the whole if and removed $value, as it was unused anyway.
  5. Christian Kuhn commented on patch set 3 12/06/12, 13:55

    Thanks for the patch. At first I already stumbled upon the commit header, could this please be a bit more precise (blank screen usually is a fatal error) ...
  6. Mattias Nilsson uploaded patch set 2 12/06/12, 13:55

  7. Mattias Nilsson commented on patch set 3 12/06/12, 13:55

    Verified; Looks good to me, but someone else must approve
  8. Markus Klein commented on patch set 4 12/06/12, 13:55

    I fully agree with Olly. As stated in the forge ticket, IMO something is wrong with the installation.
  9. Oliver Hader commented on patch set 4 12/06/12, 13:55

    I would prefer that you didn't submit this TCA should not contain empty values - if so, this has to be checked at another layer - if it fails here, it might fail in other modules as well. Thus, rewriting every module does not sound optimal, instead let's try to sanitize TCA in the bootstrap mechanisms...
  10. Oliver Hader commented on patch set 4 12/06/12, 13:55

    Releases is 6.0 only - doesn't that occur in older branches as well?
  11. Mattias Nilsson uploaded patch set 4 12/06/12, 13:55

  12. Mr. Jenkins commented on patch set 1 12/06/12, 13:55

  13. Mr. Jenkins commented on patch set 2 12/06/12, 13:55

  14. Mr. Jenkins commented on patch set 3 12/06/12, 13:55

  15. Mr. Jenkins commented on patch set 4 12/06/12, 13:55

  16. Mattias Nilsson commented on patch set 4 12/06/12, 13:55

    Abandoned