Review main Abandoned

16114[BUGFIX] Functional CategoryCollectionTest is wrong

Oliver Hader CR 0 V 0 Normal +16 −42 updated 08/17/13, 12:02

Commit message

Functional CategoryCollectionTest is wrong since it operates
on the live database and does not utilize accordant methods
in the PhpUnit framework.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 14

  1. Oliver Hader uploaded patch set 2 05/27/13, 17:19

  2. Christian Kuhn commented on patch set 3 05/27/13, 17:19

    Fails -1, must wait for https://review.typo3.org/#/c/16113
  3. Christian Kuhn commented on patch set 3 05/27/13, 17:19

    btw: i wonder how this got +1 on testing from someone, the patch failed for me immediately (eg. it throws tons of sql errors).
  4. Christian Kuhn commented on patch set 3 05/27/13, 17:19

    It might happen that the sql errors are only show if warning on cli are properly enabled. I could look up the setup i use if you are curious, Fabien.
  5. Philipp Gampe commented on patch set 3 V 0 05/27/13, 17:19

    tested with unit test
  6. Fabien Udriot uploaded patch set 3 05/27/13, 17:19

  7. Fabien Udriot commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  8. Fabien Udriot commented on patch set 3 05/27/13, 17:19

    Don't know what error is thrown.. For me, it has worked after I applied https://review.typo3.org/#/c/16113
  9. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  11. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  12. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  13. Wouter Wolters voted on patch set 3 V 0 05/27/13, 17:19

  14. Oliver Hader abandoned the change 08/17/13, 12:02