Review main Merged

16120[TASK] Cleanup update wizard configuration

Nicole Hummel CR +2 V +2 Easy +20 −26 updated 06/03/13, 20:49

Commit message

There are still some old tx_ classes in the update wizard configuration
which should be replaced with their namespaced versions.

If the classes were introduced with 6.0 we could delete and remove them
from the class map file.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 4

Review log 10

  1. Gerrit wrote 11/27/12, 00:20

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Helmut Hummel commented on patch set 1 V 0 11/27/12, 00:20

    by team member; Looks good to me, approved

    class.tx_install.php:53

    Since you fixed the paths to point to the new files, how about removing the old files? Or is there a chance that extensions require the old files?
  3. Helmut Hummel commented on patch set 1 11/27/12, 00:20

    (1 inline comment)
  4. Mr. Jenkins commented on patch set 1 11/27/12, 00:20

  5. Nicole Hummel commented on patch set 1 11/27/12, 00:20

    (1 inline comment)

    class.tx_install.php:53 Reply

    I'm not that into the update wizard yet. IMHO it's safer to keep them and drop with later release. If you say do it, of course I adjust the patch
  6. Stefan Neufeind commented on patch set 2 11/27/12, 00:20

    Looks good to me, but someone else must approve was already submitted before
  7. Mr. Jenkins commented on patch set 2 11/27/12, 00:20

  8. Nicole Hummel uploaded patch set 2 11/27/12, 00:20

  9. Helmut Hummel commented on patch set 2 V 0 11/27/12, 00:20

    by team member; Looks good to me, approved
  10. Helmut Hummel merged patch set 2 11/27/12, 00:20