16229[BUGFIX] Extension-Manager fails updating the Extension List
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 7
-
Dmitry Dulepov commented on patch set 1 04/05/13, 20:39
I would prefer that you didn't submit this I could not reproduce the issue. The Update Manager takes care of inserting a default TER record to the database and it has a proper time stamp. If the update manager did not run, the failure will happen earlier because there will be no repository at all. That would be a real problem, which we should report to the user. Currently there is no check for "null" at all. -
Markus Klein commented on patch set 1 04/05/13, 20:39
(1 inline comment) -
Oliver Klee commented on patch set 1 04/05/13, 20:39
(1 inline comment) -
Christian Kuhn commented on patch set 1 04/05/13, 20:39
I suggest to dig a bit further: afaik, the repository entry should always be there, with a correct DateTime entry. There is for example an upgrade wizard that takes care of the corresponding db record. So, the getTimestamp() call shouldn't ever fail. -
Mattias Nilsson commented on patch set 1 04/05/13, 20:39
I would prefer that you didn't submit thisUpdateFromTerController.php:108Missing "space" after if. -
Mr. Jenkins commented on patch set 1 04/05/13, 20:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6568/ : SUCCESS -
Christian Kuhn commented on patch set 1 04/05/13, 20:39
Abandoned Abandoned: the update wizard should be used to handle this.