Review main Abandoned

16229[BUGFIX] Extension-Manager fails updating the Extension List

Holger Krämer CR 0 V 0 Easy +5 −1 updated 06/03/13, 20:49

Commit message

On a fresh Installation the Extension-Manager fails updating
the Extension List.
The attached patch provides a check for the return-value of
"getTimestamp()".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Dmitry Dulepov commented on patch set 1 04/05/13, 20:39

    I would prefer that you didn't submit this I could not reproduce the issue. The Update Manager takes care of inserting a default TER record to the database and it has a proper time stamp. If the update manager did not run, the failure will happen earlier because there will be no repository at all. That would be a real problem, which we should report to the user. Currently there is no check for "null" at all.
  2. Markus Klein commented on patch set 1 04/05/13, 20:39

    (1 inline comment)
  3. Oliver Klee commented on patch set 1 04/05/13, 20:39

    (1 inline comment)
  4. Christian Kuhn commented on patch set 1 04/05/13, 20:39

    I suggest to dig a bit further: afaik, the repository entry should always be there, with a correct DateTime entry. There is for example an upgrade wizard that takes care of the corresponding db record. So, the getTimestamp() call shouldn't ever fail.
  5. Mattias Nilsson commented on patch set 1 04/05/13, 20:39

    I would prefer that you didn't submit this

    UpdateFromTerController.php:108

    Missing "space" after if.
  6. Mr. Jenkins commented on patch set 1 04/05/13, 20:39

  7. Christian Kuhn commented on patch set 1 04/05/13, 20:39

    Abandoned Abandoned: the update wizard should be used to handle this.