Review main Abandoned

16236[BUGFIX] deleteRecord_flexFormCallBack deletes file_references

Lorenz Ulrich CR 0 V 0 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Files that are referenced in a flexform
(<type>group</type><internal_type>file_reference</internal_type>)
will be deleted by t3lib_TCEmain::deleteRecord_flexFormCallBack(),
independent of the path or usage by other records.

For normal record fields (e.g. tt_content.images), only file with the
internal_type "file" are deleted. Files of internal_type "file_reference"
are respected and will not been deleted. There is an appropriate condition
in t3lib_TCEmain::extFileFunctions().

But for flexform fields, this differentiation in handling between both
internal_types is missing.

Therefore using lowlevel_cleaner or the delete option in the recycler
will delete files that may be still in use. The flexFormCallBack must
be changed to delete only files of internal_type="file".

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 2

  1. Mr. Jenkins commented on patch set 1 11/06/12, 15:03

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6571/ : FAILURE
  2. Lorenz Ulrich commented on patch set 1 11/06/12, 15:03

    Abandoned Push for wrong branch.