Review main Merged

16367[BUGFIX] Add "suggests" as valid dependency type

Tilo Baller CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

Currently extensions with "suggests" contraint in ext_emconf.php
fail to install in Extension Manager with exception
"suggestwas not a valid dependency type.".

Example (taken from EXT:saltedpasswords ext_emconf.php):
    'constraints' => array(
        [...]
        'suggests' => array(
            'rsaauth' => ''
        )
    ),

NOTE: This patch does not implement the missing handling
for suggested extensions.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Francois Suter +1
    • Oliver Hader +1
  • Verified V +2
    • Helmut Hummel +2
    • Francois Suter +1

Files 1

Review log 5

  1. Francois Suter commented on patch set 1 11/10/12, 18:27

    Verified; Looks good to me, but someone else must approve Thanks for the patch, it fixes the immediate issue. However the new EM still does not display suggestions :-(
  2. Oliver Hader commented on patch set 1 11/10/12, 18:27

    Looks good to me, but someone else must approve True... at least it avoids an exception being thrown...
  3. Mr. Jenkins commented on patch set 1 11/10/12, 18:27

  4. Helmut Hummel commented on patch set 1 V 0 11/10/12, 18:27

    by team member; Looks good to me, approved
  5. Helmut Hummel merged patch set 1 11/10/12, 18:27