Review TYPO3_4-7 Merged

16378[BUGFIX] Page Information shows incorrect number of total hits

Thomas Löffler CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

You need to install the extension "sys_stat" to show the mentioned hit
statistics.
Due to an error in the code a timestamp is displayed instead of the
actual count. Use the correct variable instead.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 7

  1. Philipp Gampe uploaded patch set 2 11/29/12, 22:08

  2. Stefan Neufeind commented on patch set 3 11/29/12, 22:08

    Looks good to me, but someone else must approve $rrow2 contains the timestamps. fix is right.
  3. Christian Kuhn commented on patch set 3 V 0 11/29/12, 22:08

    by team member; Looks good to me, approved
  4. Philipp Gampe uploaded patch set 3 11/29/12, 22:08

  5. Philipp Gampe commented on patch set 3 11/29/12, 22:08

    Verified; Looks good to me, but someone else must approve I just updated the commit message.
  6. Wouter Wolters commented on patch set 3 11/29/12, 22:08

    Looks good to me, but someone else must approve
  7. Christian Kuhn merged patch set 3 11/29/12, 22:08