Review main Merged

16449[BUGFIX] Remove dependency to iconv lib in form

Helmut Hummel CR +2 V +2 Easy +11 −4 updated 06/03/13, 20:49

Commit message

The form extension uses iconv_strlen to determine
the string length, which fails when this method
is not present in PHP.

Use the CharsetConverter class instead.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 3

Review log 3

  1. Mr. Jenkins commented on patch set 1 11/14/12, 23:51

  2. Helmut Hummel commented on patch set 1 V 0 11/14/12, 23:51

    by team member; Looks good to me, approved
  3. Helmut Hummel merged patch set 1 11/14/12, 23:51