Review main Merged

1649[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

Michael Birchler CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Steffen Gebert +1
  • Verified V +2
    • Christian Kuhn +2
    • Steffen Gebert +1

Issues 1

Files 1

Review log 6

  1. Christian Kuhn commented on patch set 2 V 0 04/19/11, 21:13

    by team member; Looks good to me, approved Obvious: The other menu classes (tmenu, jsmenu, ..) extend tslib_menu, so type hinting for the hook in tslib_menu should be bound to tslib_menu, and not just some extending class.
  2. Steffen Gebert commented on patch set 2 04/19/11, 21:13

    Verified; Looks good to me, but someone else must approve
  3. Steffen Gebert uploaded patch set 2 04/19/11, 21:13

  4. Mr. Jenkins commented on patch set 1 04/19/11, 21:13

  5. Mr. Jenkins commented on patch set 2 04/19/11, 21:13

  6. Christian Kuhn merged patch set 2 04/19/11, 21:13