16518[FEATURE] Introduce ClassNamingUtility
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Markus Günther +1
-
Verified V +2
- Andreas Wolf +2
- Markus Günther +1
Files 2
Review log 15
-
Stefan Neufeind commented on patch set 1 02/10/13, 14:25
Verified; Looks good to me, but someone else must approve But for 6.1vise => vice6.1 nowClassNamingUtility.php:47Simply str_replace maybe? Should be faster. And I expect such a classnaming-util might possibly be used in some central place / called often.ClassNamingUtility.php:48Three backslashes? I would have expected two or four ... and think two might be correct here.ClassNamingUtility.php:48Add underscores in front/at the back as in function below? Same for the extra \\ at the end imhoClassNamingUtility.php:65two backslashes maybe? Possibly followed by another \\ to make sure it appears "in the middle" of such a name and does not trigger on whatever (strange) \\ModelSomething or so?ClassNamingUtility.php:81also add those additional slashes/underscores like in comment above? Imho four backslashes instead of three? One to escape them and one another for each (doubling it again) to escape them because of the preg. Tried locally that it works with 3 and 4 the same way ... hmm, I would have expected a warning with three backslashes since the last one isn't properly escaped imho. But it works as is ...ClassNamingUtility.php:100TYPO3\\CMS imhoClassNamingUtilityTest.php:33and translateModelNameToValidatorNameClassNamingUtilityTest.php:118should we add a third dummy-parameter here since the dataProvider returns three values? Although the last one isn't used in this test. Same for test below. -
Andreas Wolf uploaded patch set 3 02/10/13, 14:25
-
Andreas Wolf commented on patch set 3 02/10/13, 14:25
Verified; Looks good to me, but someone else must approve -
Andreas Wolf commented on patch set 3 02/10/13, 14:25
Ran unit tests and extended them, also added a new method to test the model->validator transformation. -
Andreas Wolf commented on patch set 3 V 0 02/10/13, 14:25
by team member; Looks good to me, approved -
Andreas Wolf merged patch set 4 02/10/13, 14:25
-
Stefan Neufeind commented on patch set 2 02/10/13, 14:25
(3 inline comments) -
Stefan Neufeind commented on patch set 3 02/10/13, 14:25
(5 inline comments) -
Stefan Neufeind commented on patch set 4 02/10/13, 14:25
just some nitpicks -
Markus Günther commented on patch set 3 02/10/13, 14:25
Verified; Looks good to me, but someone else must approve Cool! Thanks for that new Utility. -
Anja Leichsenring uploaded patch set 2 02/10/13, 14:25
-
Mr. Jenkins commented on patch set 1 02/10/13, 14:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6664/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/10/13, 14:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7006/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/10/13, 14:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7435/ : SUCCESS -
Stefan Neufeind commented on patch set 4 02/10/13, 14:25
follow-up at https://review.typo3.org/18189