Review main Merged

16577[BUGFIX] Replace calls of tslib_gifbuilder with namespaced class

Nicole Hummel CR +2 V +2 Normal +37 −36 updated 06/03/13, 20:49

Commit message

In some functions the old class tslib_gifbuilder is still called and
should be replaces with the namespaced class.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 9

Review log 10

  1. Christian Kuhn commented on patch set 1 11/19/12, 19:07

    I would prefer that you didn't submit this

    ContentObjectRenderer.php:5012

    why is this array check removed?
  2. Philipp Gampe commented on patch set 1 11/19/12, 19:07

    +1 except comment from Christian
  3. Mr. Jenkins commented on patch set 1 11/19/12, 19:07

  4. Christian Kuhn uploaded patch set 3 11/19/12, 19:07

  5. Christian Kuhn commented on patch set 3 11/19/12, 19:07

    just one occurrence in a comment was missing.
  6. Mr. Jenkins commented on patch set 2 11/19/12, 19:07

  7. Nicole Hummel commented on patch set 2 11/19/12, 19:07

    Sorry, was working on another issue while sawing this. Checkout a new branch but forgot to stash my changes so far.
  8. Nicole Hummel uploaded patch set 2 11/19/12, 19:07

  9. Christian Kuhn commented on patch set 3 V 0 11/19/12, 19:07

    by team member; Looks good to me, approved
  10. Christian Kuhn merged patch set 3 11/19/12, 19:07