16577[BUGFIX] Replace calls of tslib_gifbuilder with namespaced class
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Files 9
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+19 −19
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+2 −2
- typo3/sysext/core/Classes/Resource/Service/ImageProcessingService.php+3 −3
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/css_styled_content/Classes/Controller/CssStyledContentController.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php1+8 −7
- typo3/sysext/frontend/Classes/ContentObject/ImageTextContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −1
Review log 10
-
Christian Kuhn commented on patch set 1 11/19/12, 19:07
I would prefer that you didn't submit thisContentObjectRenderer.php:5012why is this array check removed? -
Philipp Gampe commented on patch set 1 11/19/12, 19:07
+1 except comment from Christian -
Mr. Jenkins commented on patch set 1 11/19/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6690/ : SUCCESS -
Christian Kuhn uploaded patch set 3 11/19/12, 19:07
-
Christian Kuhn commented on patch set 3 11/19/12, 19:07
just one occurrence in a comment was missing. -
Mr. Jenkins commented on patch set 2 11/19/12, 19:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6691/ : SUCCESS -
Nicole Hummel commented on patch set 2 11/19/12, 19:07
Sorry, was working on another issue while sawing this. Checkout a new branch but forgot to stash my changes so far. -
Nicole Hummel uploaded patch set 2 11/19/12, 19:07
-
Christian Kuhn commented on patch set 3 V 0 11/19/12, 19:07
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 11/19/12, 19:07