Review main Merged

16595[BUGFIX] Some unit tests fail in Core::FolderTest

Nicole Hummel CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

Due to use of type hint callable which is available at PHP 5.4 unit tests
fail for lower PHP versions.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 11/26/12, 23:09

    Looks good to me, but someone else must approve no pre-5.4 at hand with a test-setup :-( But makes sense by reading. No-brainer?
  2. Philipp Gampe commented on patch set 1 11/26/12, 23:09

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 11/26/12, 23:09

  4. Wouter Wolters commented on patch set 1 11/26/12, 23:09

    Looks good to me, but someone else must approve Indeed introduced in PHP 5.4 See http://www.php.net/manual/en/language.types.callable.php
  5. Wouter Wolters commented on patch set 1 V 0 11/26/12, 23:09

    Fails without this patch.
  6. Helmut Hummel commented on patch set 1 V 0 11/26/12, 23:09

    by team member; Looks good to me, approved
  7. Helmut Hummel merged patch set 1 11/26/12, 23:09