16596[BUGFIX] Some unit tests fail in Core::LocalDriverTest
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Oliver Klee +1
- Wouter Wolters +1
- Jigal van Hemert +1
- Philipp Gampe +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
- Jigal van Hemert +1
- Philipp Gampe +1
Files 2
Review log 12
-
Mr. Jenkins commented on patch set 1 11/20/12, 18:34
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6706/ : FAILURE -
Christian Kuhn commented on patch set 2 11/20/12, 18:34
(2 inline comments)LocalDriver.php:30this line should be directly after the namespace definition (before license block)LocalDriverTest.php:30directly after namespace definition, please. -
Mr. Jenkins commented on patch set 2 11/20/12, 18:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6707/ : SUCCESS -
Nicole Hummel uploaded patch set 2 11/20/12, 18:34
-
Oliver Klee commented on patch set 3 11/20/12, 18:34
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 3 11/20/12, 18:34
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 11/20/12, 18:34
Verified; Looks good to me, but someone else must approve Tested on Fedora with Unit Test: 80 tests, 208 assertions, 0 failures, 0 skipped, 0 incomplete, 0 errors, 2.13 seconds, 13.1 MB (13733352 B) memory leaks -
Mr. Jenkins commented on patch set 3 11/20/12, 18:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6709/ : SUCCESS -
Wouter Wolters commented on patch set 3 11/20/12, 18:34
Verified; Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 3 11/20/12, 18:34
-
Helmut Hummel commented on patch set 3 V 0 11/20/12, 18:34
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 3 11/20/12, 18:34