Review main Merged

16596[BUGFIX] Some unit tests fail in Core::LocalDriverTest

Nicole Hummel CR +2 V +2 Easy +15 −5 updated 06/03/13, 20:49

Commit message

Some tests fail on Windows systems. Mostly this is because of a missing
file and folder permission handling. Those tests have to be skipped.
Furthermore there is some path fixing needed in basic class.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Jigal van Hemert +1
    • Philipp Gampe +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Jigal van Hemert +1
    • Philipp Gampe +1

Files 2

Review log 12

  1. Mr. Jenkins commented on patch set 1 11/20/12, 18:34

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6706/ : FAILURE
  2. Christian Kuhn commented on patch set 2 11/20/12, 18:34

    (2 inline comments)

    LocalDriver.php:30

    this line should be directly after the namespace definition (before license block)

    LocalDriverTest.php:30

    directly after namespace definition, please.
  3. Mr. Jenkins commented on patch set 2 11/20/12, 18:34

  4. Nicole Hummel uploaded patch set 2 11/20/12, 18:34

  5. Oliver Klee commented on patch set 3 11/20/12, 18:34

    Looks good to me, but someone else must approve
  6. Jigal van Hemert commented on patch set 3 11/20/12, 18:34

    Verified; Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 3 11/20/12, 18:34

    Verified; Looks good to me, but someone else must approve Tested on Fedora with Unit Test: 80 tests, 208 assertions, 0 failures, 0 skipped, 0 incomplete, 0 errors, 2.13 seconds, 13.1 MB (13733352 B) memory leaks
  8. Mr. Jenkins commented on patch set 3 11/20/12, 18:34

  9. Wouter Wolters commented on patch set 3 11/20/12, 18:34

    Verified; Looks good to me, but someone else must approve
  10. Nicole Hummel uploaded patch set 3 11/20/12, 18:34

  11. Helmut Hummel commented on patch set 3 V 0 11/20/12, 18:34

    by team member; Looks good to me, approved
  12. Helmut Hummel merged patch set 3 11/20/12, 18:34