Review main Abandoned

16597[BUGFIX] BaseTestCase throws a warning because of missing tests

Nicole Hummel CR 0 V 0 Easy +7 −0 updated 06/03/13, 20:49

Commit message

As the abstract class BaseTestCase doesn't contain any test PHPUnit throws
a warning when executing the whole core test. To prevent this a pseudo
test which is skipped has to be inserted.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 10

  1. Stefan Neufeind commented on patch set 1 04/07/13, 09:11

    Verified; Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 1 04/07/13, 09:11

    I'd prefer that PHPUnit does not execute this test case at all, i.e., this looks more like a PHPUnit issue to me.
  3. Oliver Klee commented on patch set 1 04/07/13, 09:11

    I would prefer that you didn't submit this I'll take care of this in the PHPUnit extension.
  4. Oliver Klee commented on patch set 1 04/07/13, 09:11

    I've fixed this in the PHPUnit extension: https://review.typo3.org/#/c/16809/ So this change set should be abandoned.
  5. Helmut Hummel commented on patch set 1 04/07/13, 09:11

    I agree with Oli here. Any hints to reproduce this warning?
  6. Helmut Hummel commented on patch set 1 04/07/13, 09:11

    Do not submit No Problem at all on CLI. Should be fixed in the phpunit extension
  7. Philipp Gampe commented on patch set 1 04/07/13, 09:11

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 04/07/13, 09:11

  9. Nicole Hummel commented on patch set 1 04/07/13, 09:11

    You can reproduce this by running all tests from core extension at once
  10. Benni Mack commented on patch set 1 04/07/13, 09:11

    Abandoned see info from Oli Klee