Review main Merged

16598[TASK] Integrate possibility to call inaccessible methods in BaseTestCase

Oliver Hader CR +2 V +2 Easy +31 −19 updated 06/03/13, 20:49

Commit message

The BaseTestCase already has a possibility to create full blown
accessible object proxies. However if one does not want to have
the class stack cluttered with temporary existing classes, there
shall be a possibility to directly invoke protected/private
methods of a fixture object.

The new method callInaccessibleMethod method is taken and
rewritten from ModuleControllerTest.

Example to use it in unit tests:
$this->fixture = new \TYPO3\CMS\Core\SomeClassName();
$result = $this->callInaccessibleMethod(
  $this->fixture,
  'privateMethod',
  $first, $second, $third, ...
);

Review

  • Code review CR +2
    • Oliver Hader +2
    • Philipp Gampe +1
  • Verified V +2
    • Oliver Hader +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 8

  1. Oliver Hader commented on patch set 1 11/20/12, 13:18

    Damn Jenkins! If there were no other things to todo currently
  2. Philipp Gampe commented on patch set 1 11/20/12, 13:18

    Looks good to me, but someone else must approve
  3. Philipp Gampe uploaded patch set 2 11/20/12, 13:18

  4. Philipp Gampe commented on patch set 2 11/20/12, 13:18

    Verified; Looks good to me, but someone else must approve I just fixed the newline warning.
  5. Mr. Jenkins commented on patch set 1 11/20/12, 13:18

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6711/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 11/20/12, 13:18

  7. Oliver Hader commented on patch set 2 V 0 11/20/12, 13:18

    by team member; Looks good to me, approved Thanks Philipp
  8. Oliver Hader merged patch set 2 11/20/12, 13:18