1661[BUGFIX] Fix inconsistent linebreaks in some files
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
Issues 1
Files 5
Review log 15
-
Michael Stucki uploaded patch set 2 04/25/11, 20:27
-
Michael Stucki commented on patch set 2 04/25/11, 20:27
Do not submit Well, I accidentially committed the 4-5 patch with the same change ID. -
Michael Stucki uploaded patch set 3 04/25/11, 20:27
-
Michael Stucki commented on patch set 3 04/25/11, 20:27
No score Should be fine again now. -
Michael Stucki commented on patch set 3 04/25/11, 20:27
Hey Steffen, all I did was to run "dos2unix <filename>" so other than this, no changes were added or removed. For any of your suggestions, I suggest that if we do this, then it should be done in different change requests... - michael -
Susi Moog commented on patch set 3 04/25/11, 20:27
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 3 04/25/11, 20:27
(2 inline comments)GridFilters.css:22Could you just remove those lines, as they're commented out..GridFilters.css:41Hell yeah.. -
Mr. Jenkins commented on patch set 1 04/25/11, 20:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/308/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/25/11, 20:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/309/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/25/11, 20:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/310/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/25/11, 20:27
I am testing just some things. If all works well, I will complain about CGL issues very soon. -
Mr. Jenkins commented on patch set 3 04/25/11, 20:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/312/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/25/11, 20:27
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/313/ : SUCCESS -
Christian Kuhn commented on patch set 3 V 0 04/25/11, 20:27
by team member; Looks good to me, approved This patch is a no-brainer as such. Merged. Still, we could fix CGL and comments to make those files compatible with our CGL. -
Christian Kuhn merged patch set 3 04/25/11, 20:27