Review main Merged

1661[BUGFIX] Fix inconsistent linebreaks in some files

Michael Stucki CR +2 V +2 Expert +817 −817 updated 06/03/13, 20:49

Commit message

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 5

Review log 15

  1. Michael Stucki uploaded patch set 2 04/25/11, 20:27

  2. Michael Stucki commented on patch set 2 04/25/11, 20:27

    Do not submit Well, I accidentially committed the 4-5 patch with the same change ID.
  3. Michael Stucki uploaded patch set 3 04/25/11, 20:27

  4. Michael Stucki commented on patch set 3 04/25/11, 20:27

    No score Should be fine again now.
  5. Michael Stucki commented on patch set 3 04/25/11, 20:27

    Hey Steffen, all I did was to run "dos2unix <filename>" so other than this, no changes were added or removed. For any of your suggestions, I suggest that if we do this, then it should be done in different change requests... - michael
  6. Susi Moog commented on patch set 3 04/25/11, 20:27

    Verified; Looks good to me, but someone else must approve
  7. Steffen Gebert commented on patch set 3 04/25/11, 20:27

    (2 inline comments)

    GridFilters.css:22

    Could you just remove those lines, as they're commented out..

    GridFilters.css:41

    Hell yeah..
  8. Mr. Jenkins commented on patch set 1 04/25/11, 20:27

  9. Mr. Jenkins commented on patch set 2 04/25/11, 20:27

  10. Mr. Jenkins commented on patch set 3 04/25/11, 20:27

  11. Mr. Jenkins commented on patch set 3 04/25/11, 20:27

    I am testing just some things. If all works well, I will complain about CGL issues very soon.
  12. Mr. Jenkins commented on patch set 3 04/25/11, 20:27

  13. Mr. Jenkins commented on patch set 3 04/25/11, 20:27

  14. Christian Kuhn commented on patch set 3 V 0 04/25/11, 20:27

    by team member; Looks good to me, approved This patch is a no-brainer as such. Merged. Still, we could fix CGL and comments to make those files compatible with our CGL.
  15. Christian Kuhn merged patch set 3 04/25/11, 20:27