Review main Merged

16629[BUGFIX] RootlineUtility uses backticks which leads to crashing dbal

Nicole Hummel CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

In some queries backticks are used to generate the WHERE clause. Those
backticks lead to an error when using dbal. Therefore they have to be
removed.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Helmut Hummel +2
    • Philipp Gampe +1

Files 1

Review log 5

  1. Helmut Hummel commented on patch set 1 V 0 11/20/12, 17:51

    by team member; Looks good to me, approved
  2. Philipp Gampe commented on patch set 1 11/20/12, 17:51

    Verified; Looks good to me, but someone else must approve just tested by clicking around in backend and frontent
  3. Mr. Jenkins commented on patch set 1 11/20/12, 17:51

  4. Wouter Wolters commented on patch set 1 11/20/12, 17:51

    Looks good to me, but someone else must approve
  5. Helmut Hummel merged patch set 1 11/20/12, 17:51