Review main Abandoned

16632[BUGFIX] Old logo on "Install Tool is locked" page

Nikolas Schmidt-Voigt CR 0 V 0 Easy +7 −7 updated 06/03/13, 20:49

Commit message

The page that warned users that the install tool is locked still
showed the old TYPO3 logo. I corrected this by changing the logo.

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 5

  1. Mr. Jenkins commented on patch set 1 11/20/12, 20:15

  2. Wouter Wolters commented on patch set 1 11/20/12, 20:15

    You only did one thing not completly right. You created a new change instead of pushing a new patchset. By amending the commit you will upload a new patchset. Can you abandon this change? Will test the other patch this evening:) If you have further questions just ask;-)
  3. Wouter Wolters commented on patch set 1 11/20/12, 20:15

    Thanks for the patch Nikolas. You submitted also some submodule pointers that are not needed. Can you resubmit the patch? Try doing a git submodule update --init and then git commit -a --amend to upload a new patchset. Is this also needed for older branches? Like 4.7
  4. Nikolas Schmidt-Voigt commented on patch set 1 11/20/12, 20:15

    Thanks for reviewing the patch, Wouter. I changed the patch, so it does not cover the unneeded submodule pointers anymore. As far as I now the new logo is only used in version 6. Former versions still use the old logo.
  5. Nikolas Schmidt-Voigt commented on patch set 1 11/20/12, 20:15

    Abandoned I am not familiar with git and gerrit yet. I abandon this change so we can use the other patch.