16632[BUGFIX] Old logo on "Install Tool is locked" page
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 7
Review log 5
-
Mr. Jenkins commented on patch set 1 11/20/12, 20:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6721/ : SUCCESS -
Wouter Wolters commented on patch set 1 11/20/12, 20:15
You only did one thing not completly right. You created a new change instead of pushing a new patchset. By amending the commit you will upload a new patchset. Can you abandon this change? Will test the other patch this evening:) If you have further questions just ask;-) -
Wouter Wolters commented on patch set 1 11/20/12, 20:15
Thanks for the patch Nikolas. You submitted also some submodule pointers that are not needed. Can you resubmit the patch? Try doing a git submodule update --init and then git commit -a --amend to upload a new patchset. Is this also needed for older branches? Like 4.7 -
Nikolas Schmidt-Voigt commented on patch set 1 11/20/12, 20:15
Thanks for reviewing the patch, Wouter. I changed the patch, so it does not cover the unneeded submodule pointers anymore. As far as I now the new logo is only used in version 6. Former versions still use the old logo. -
Nikolas Schmidt-Voigt commented on patch set 1 11/20/12, 20:15
Abandoned I am not familiar with git and gerrit yet. I abandon this change so we can use the other patch.