16635[BUGFIX] Fallback of FAL properties does not work
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Files 3
Review log 8
-
Andreas Wolf commented on patch set 1 11/20/12, 22:09
Looks good to me, but someone else must approve I think we should have unit tests for the property overlay stuff.AbstractFile.php:111No need for array_keys() here. -
Oliver Hader commented on patch set 1 11/20/12, 22:09
(1 inline comment) DoneAbstractFile.php:111ReplyDone. I was thinking in in_array(...) -
Oliver Hader uploaded patch set 2 11/20/12, 22:09
-
Mr. Jenkins commented on patch set 1 11/20/12, 22:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6727/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/20/12, 22:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6734/ : SUCCESS -
Wouter Wolters commented on patch set 1 11/20/12, 22:09
Looks good to me, but someone else must approve -
Oliver Hader commented on patch set 2 V 0 11/20/12, 22:09
by team member; Looks good to me, approved -
Oliver Hader merged patch set 2 11/20/12, 22:09