Review main Merged

16635[BUGFIX] Fallback of FAL properties does not work

Oliver Hader CR +2 V +2 Normal +59 −10 updated 06/03/13, 20:49

Commit message

The fields title, description and alternative are available
in file references and files. If those in file references
are not defined, those of files shall be used.

Besides that, some fields are not configured yet to be shown
as placeholder element in the backend.

The flaws are fixed by adding accordant TCA configuration and
adding the fallback behaviour for the FileReference object.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Files 3

Review log 8

  1. Andreas Wolf commented on patch set 1 11/20/12, 22:09

    Looks good to me, but someone else must approve I think we should have unit tests for the property overlay stuff.

    AbstractFile.php:111

    No need for array_keys() here.
  2. Oliver Hader commented on patch set 1 11/20/12, 22:09

    (1 inline comment) Done

    AbstractFile.php:111 Reply

    Done. I was thinking in in_array(...)
  3. Oliver Hader uploaded patch set 2 11/20/12, 22:09

  4. Mr. Jenkins commented on patch set 1 11/20/12, 22:09

  5. Mr. Jenkins commented on patch set 2 11/20/12, 22:09

  6. Wouter Wolters commented on patch set 1 11/20/12, 22:09

    Looks good to me, but someone else must approve
  7. Oliver Hader commented on patch set 2 V 0 11/20/12, 22:09

    by team member; Looks good to me, approved
  8. Oliver Hader merged patch set 2 11/20/12, 22:09