Review main Merged

16636[BUGFIX] Deactivated textarea elements are not visualized

Oliver Hader CR +2 V +2 Easy +5 −13 updated 06/03/13, 20:49

Commit message

Deactivated textarea elements, fields that have a NULL value
stored in the database, are not visualized correctly when
loading the backend editing form. The status is currently set
using JavaScript and triggered by TBE_EDITOR.fieldSet().
However, textareas don't have a human readable clone and thus
fieldSet() is not called and thus no status is set.

This issue is fixed by directly rendering the status in the
FormEngine.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
  • Verified V +2
    • Oliver Hader +2
    • Wouter Wolters +1

Files 3

Review log 5

  1. Mr. Jenkins commented on patch set 1 11/20/12, 23:38

  2. Wouter Wolters commented on patch set 1 11/20/12, 23:38

    Looks good to me, but someone else must approve
  3. Wouter Wolters voted on patch set 1 V 0 11/20/12, 23:38

  4. Oliver Hader commented on patch set 1 V 0 11/20/12, 23:38

    by team member; Looks good to me, approved
  5. Oliver Hader merged patch set 1 11/20/12, 23:38