Review main Merged

16686[FEATURE] Expand db function searchQuery to handle AND and OR constraints

Nicole Hummel CR +2 V +2 Normal +102 −4 updated 06/03/13, 20:49

Commit message

The database function searchQuery can build queries for multiple search
words. But those words are expected to be all in the field. Sometimes it
is useful to use an OR constraint. So this function should be extended to
have another parameter to do so.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 2

Review log 10

  1. Stefan Neufeind commented on patch set 2 12/02/12, 13:40

    Looks good to me, but someone else must approve +1 in itself. I'm just unsure if "constraint" is the correct term here. Aren't Constraints things that limit a query (like a "WHERE constraint")? Might conjunction be more appropriate? While the "AND" actually limits / constrains a query in some way the OR on the other hand possibly widens the results.
    6.1
  2. Stefan Neufeind commented on patch set 2 12/02/12, 13:40

    (1 inline comment)
  3. Helmut Hummel commented on patch set 2 12/02/12, 13:40

    I'm fine, if this goes into 6.1, but not 6.0 any more...
  4. Jigal van Hemert uploaded patch set 3 12/02/12, 13:40

  5. Philipp Gampe commented on patch set 2 12/02/12, 13:40

    Verified; Looks good to me, but someone else must approve I changed database to db in the commit message.
  6. Philipp Gampe uploaded patch set 2 12/02/12, 13:40

  7. Mr. Jenkins commented on patch set 1 12/02/12, 13:40

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6756/ : FAILURE
  8. Mr. Jenkins commented on patch set 2 12/02/12, 13:40

  9. Jigal van Hemert commented on patch set 3 V 0 12/02/12, 13:40

    by team member; Looks good to me, approved Rebased and raised version to 6.1; previous votes still valid.
  10. Jigal van Hemert merged patch set 3 12/02/12, 13:40