Review main Merged

16697[TASK] Allow Folder and Storage to recursively retrieve Files from Driver

Steffen Ritter CR +2 V +2 Normal +79 −15 updated 06/03/13, 20:49

Commit message

The drivers in FAL are capable of retrieving files recursively.
This might be sinful in some cases and custom usages. Anyhow,
the parameter $recursive is not passed up until Storage and
Folder objects. With that users are forced to work with the
driver directly.

As it is highly discouraged to work directly on the driver,
just pass up the parameter within the abstraction layers.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 6

Review log 17

  1. Oliver Klee commented on patch set 2 11/25/12, 15:44

    Can we cover this feature with unit tests (at least so we know that it works in the first place)?
  2. Oliver Klee commented on patch set 2 11/25/12, 15:44

    I think testing that TRUE and FALSE get passed on (and the default value) would be enough.
  3. Steffen Ritter commented on patch set 2 11/25/12, 15:44

    what would you like to see tests? that the parameter arrives in the driver, (that's the change) or do you want to test, that the abstract driver uses the RecursiveIterator if the flag is set? Both possible, but the latter would be another changeset I think.

    Folder.php:215 Reply

    small performance matter, to just count the files I do not need to load the index records from db for enhancement of the file objects ;)
  4. Steffen Ritter uploaded patch set 2 11/25/12, 15:44

  5. Helmut Hummel commented on patch set 3 11/25/12, 15:44

    (1 inline comment)

    Folder.php:215

    Why did you change the default her to FALSE?
  6. Helmut Hummel commented on patch set 3 11/25/12, 15:44

    (1 inline comment)
  7. Helmut Hummel commented on patch set 3 11/25/12, 15:44

    Fails Tests are failing
  8. Steffen Ritter uploaded patch set 3 11/25/12, 15:44

  9. Steffen Ritter commented on patch set 3 11/25/12, 15:44

    (1 inline comment)
  10. Steffen Ritter uploaded patch set 4 11/25/12, 15:44

  11. Philipp Gampe commented on patch set 2 11/25/12, 15:44

    Looks good to me, but someone else must approve
  12. Mr. Jenkins commented on patch set 1 11/25/12, 15:44

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6761/ : FAILURE
  13. Mr. Jenkins commented on patch set 2 11/25/12, 15:44

  14. Mr. Jenkins commented on patch set 3 11/25/12, 15:44

  15. Mr. Jenkins commented on patch set 4 11/25/12, 15:44

  16. Helmut Hummel commented on patch set 4 V 0 11/25/12, 15:44

    by team member; Looks good to me, approved
  17. Helmut Hummel merged patch set 4 11/25/12, 15:44