16697[TASK] Allow Folder and Storage to recursively retrieve Files from Driver
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
Files 6
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+8 −5
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+3 −2
- typo3/sysext/core/Classes/Resource/Folder.php3+5 −4
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+6 −4
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+30 −0
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+27 −0
Review log 17
-
Oliver Klee commented on patch set 2 11/25/12, 15:44
Can we cover this feature with unit tests (at least so we know that it works in the first place)? -
Oliver Klee commented on patch set 2 11/25/12, 15:44
I think testing that TRUE and FALSE get passed on (and the default value) would be enough. -
Steffen Ritter commented on patch set 2 11/25/12, 15:44
what would you like to see tests? that the parameter arrives in the driver, (that's the change) or do you want to test, that the abstract driver uses the RecursiveIterator if the flag is set? Both possible, but the latter would be another changeset I think.Folder.php:215Replysmall performance matter, to just count the files I do not need to load the index records from db for enhancement of the file objects ;) -
Steffen Ritter uploaded patch set 2 11/25/12, 15:44
-
Helmut Hummel commented on patch set 3 11/25/12, 15:44
(1 inline comment)Folder.php:215Why did you change the default her to FALSE? -
Helmut Hummel commented on patch set 3 11/25/12, 15:44
(1 inline comment) -
Helmut Hummel commented on patch set 3 11/25/12, 15:44
Fails Tests are failing -
Steffen Ritter uploaded patch set 3 11/25/12, 15:44
-
Steffen Ritter commented on patch set 3 11/25/12, 15:44
(1 inline comment) -
Steffen Ritter uploaded patch set 4 11/25/12, 15:44
-
Philipp Gampe commented on patch set 2 11/25/12, 15:44
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 11/25/12, 15:44
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6761/ : FAILURE -
Mr. Jenkins commented on patch set 2 11/25/12, 15:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6762/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/25/12, 15:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6783/ : SUCCESS -
Mr. Jenkins commented on patch set 4 11/25/12, 15:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6796/ : SUCCESS -
Helmut Hummel commented on patch set 4 V 0 11/25/12, 15:44
by team member; Looks good to me, approved -
Helmut Hummel merged patch set 4 11/25/12, 15:44