Review main Merged

16715[BUGFIX] FormWizard does not save

Florian Scholz CR +2 V +2 Easy +0 −0 updated 06/03/13, 20:49

Commit message

This adds a mapping for the JsonToTyposcript class to resolve
the wrong instantiation due to different versions of file and
class names (Typoscript vs TypoScript).

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 14

  1. Steffen Ritter commented on patch set 1 11/25/12, 18:09

    Hi Florian, your IDE inserted an empty newline after the closing PHP tag (?>). This is against TYPO3 CGL and therefore Mr. Jenkins votes done your patch.
  2. Mr. Jenkins commented on patch set 1 11/25/12, 18:09

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6774/ : FAILURE
  3. Helmut Hummel commented on patch set 2 11/25/12, 18:09

    I would prefer that you didn't submit this

    ClassAliasMap.php:6

    alias definition must be the other way around: old -> new
  4. Helmut Hummel uploaded patch set 3 11/25/12, 18:09

  5. Helmut Hummel commented on patch set 3 11/25/12, 18:09

    I would prefer that you didn't submit this Hm, why is his needed at all? $converter = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Form\\Domain\\Factory\\JsonToTypoScript'); Looks good
  6. Helmut Hummel uploaded patch set 4 11/25/12, 18:09

  7. Helmut Hummel commented on patch set 5 V 0 11/25/12, 18:09

    by team member; Looks good to me, approved ah, OK I see. The file should be renamed to match the class
  8. Helmut Hummel uploaded patch set 5 11/25/12, 18:09

  9. Steffen Ritter commented on patch set 2 11/25/12, 18:09

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 2 11/25/12, 18:09

  11. Mr. Jenkins commented on patch set 3 11/25/12, 18:09

  12. Wouter Wolters commented on patch set 2 11/25/12, 18:09

    Looks good to me, but someone else must approve
  13. Florian Scholz uploaded patch set 2 11/25/12, 18:09

  14. Helmut Hummel merged patch set 5 11/25/12, 18:09