16715[BUGFIX] FormWizard does not save
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
Issues 1
Files 1
Review log 14
-
Steffen Ritter commented on patch set 1 11/25/12, 18:09
Hi Florian, your IDE inserted an empty newline after the closing PHP tag (?>). This is against TYPO3 CGL and therefore Mr. Jenkins votes done your patch. -
Mr. Jenkins commented on patch set 1 11/25/12, 18:09
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6774/ : FAILURE -
Helmut Hummel commented on patch set 2 11/25/12, 18:09
I would prefer that you didn't submit thisClassAliasMap.php:6alias definition must be the other way around: old -> new -
Helmut Hummel uploaded patch set 3 11/25/12, 18:09
-
Helmut Hummel commented on patch set 3 11/25/12, 18:09
I would prefer that you didn't submit this Hm, why is his needed at all? $converter = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Form\\Domain\\Factory\\JsonToTypoScript'); Looks good -
Helmut Hummel uploaded patch set 4 11/25/12, 18:09
-
Helmut Hummel commented on patch set 5 V 0 11/25/12, 18:09
by team member; Looks good to me, approved ah, OK I see. The file should be renamed to match the class -
Helmut Hummel uploaded patch set 5 11/25/12, 18:09
-
Steffen Ritter commented on patch set 2 11/25/12, 18:09
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 2 11/25/12, 18:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6792/ : SUCCESS -
Mr. Jenkins commented on patch set 3 11/25/12, 18:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6802/ : SUCCESS -
Wouter Wolters commented on patch set 2 11/25/12, 18:09
Looks good to me, but someone else must approve -
Florian Scholz uploaded patch set 2 11/25/12, 18:09
-
Helmut Hummel merged patch set 5 11/25/12, 18:09