Review main Merged

16724[TASK] Protect bootstrap methods

Christian Kuhn CR +2 V +2 Hard +205 −165 updated 06/03/13, 20:49

Commit message

With 6.0 the bootstrap related core code was split into small methods
and transferred to a group of encapsulating classes.
While this is an important step to get a flexible and maintainable
bootstrap in the end, this process is not completed and still misses
for example a real concept for scopes.
The patch groups methods used in all scopes in bootstrap wrapper
methods and makes the business methods protected. The whole API and
all affected classes are marked as "internal", together with a
warning that this API will change in the future and shouldn't be
used by 3rd party code that is not under core control.
This gives freedom for future development of this core code without
taking care of backwards compatibility. With previous versions there
was no API at all, so this is not a feature loss from an extension
point of view.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Steffen Ritter +1
  • Verified V +2
    • Helmut Hummel +2
    • Steffen Ritter +1

Issues 1

Files 11

Review log 4

  1. Helmut Hummel commented on patch set 1 V 0 11/25/12, 20:25

    by team member; Looks good to me, approved
  2. Steffen Ritter commented on patch set 1 11/25/12, 20:25

    Verified; Looks good to me, but someone else must approve seems stuff comes up
  3. Mr. Jenkins commented on patch set 1 11/25/12, 20:25

  4. Helmut Hummel merged patch set 1 11/25/12, 20:25