Review main Merged

16753[BUGFIX] Fix Non-static method tslib_cObj::getKey()

Wouter Wolters CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Non-static method tslib_cObj::getKey() should
not be called statically

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 1 04/12/13, 20:01

    Looks good to me, but someone else must approve
  2. Benni Mack commented on patch set 1 04/12/13, 20:01

    Looks good to me, but someone else must approve
  3. Stefan Neufeind commented on patch set 2 04/12/13, 20:01

    Just stumbled across this bug: http://forge.typo3.org/issues/44430 The same issue also applies to TYPO3-versions prior to 6.0. It's just of course not namespaced there but tslib_cObj::getKey(). Oh, and that's what this patch has in the commit-msg although this patch here uses namespaces :-)
  4. Christian Kuhn uploaded patch set 2 04/12/13, 20:01

  5. Christian Kuhn commented on patch set 2 04/12/13, 20:01

    Verified; Looks good to me, but someone else must approve
  6. Georg Ringer commented on patch set 2 V 0 04/12/13, 20:01

    by team member; Looks good to me, approved
  7. Mr. Jenkins commented on patch set 1 04/12/13, 20:01

  8. Mr. Jenkins commented on patch set 2 04/12/13, 20:01

  9. Georg Ringer merged patch set 3 04/12/13, 20:01