16753[BUGFIX] Fix Non-static method tslib_cObj::getKey()
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2
- Georg Ringer +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 9
-
Stefan Neufeind commented on patch set 1 04/12/13, 20:01
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 1 04/12/13, 20:01
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 04/12/13, 20:01
Just stumbled across this bug: http://forge.typo3.org/issues/44430 The same issue also applies to TYPO3-versions prior to 6.0. It's just of course not namespaced there but tslib_cObj::getKey(). Oh, and that's what this patch has in the commit-msg although this patch here uses namespaces :-) -
Christian Kuhn uploaded patch set 2 04/12/13, 20:01
-
Christian Kuhn commented on patch set 2 04/12/13, 20:01
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 V 0 04/12/13, 20:01
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 04/12/13, 20:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6823/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/12/13, 20:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8365/ : SUCCESS -
Georg Ringer merged patch set 3 04/12/13, 20:01