16754[BUGFIX] Fix Non-static method tslib_cObj::calc()
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stefan Neufeind +1
- Christian Kuhn +1
-
Verified V +2
- Georg Ringer +2
- Christian Kuhn +1
Issues 1
Files 3
Review log 21
-
Stefan Neufeind commented on patch set 1 04/12/13, 19:47
Looks good to me, but someone else must approve -
Benni Mack uploaded patch set 2 04/12/13, 19:47
-
Christian Kuhn commented on patch set 2 04/12/13, 19:47
(1 inline comment)6.1, 6.0ContentObjectRenderer.php:4307be careful here: calcIntExplode itself is also called statically at some point, so this will not work. -
Philipp Gampe commented on patch set 1 04/12/13, 19:47
Looks good to me, but someone else must approve Assuming that $this->parent_cObject is always set. -
Mr. Jenkins commented on patch set 1 04/12/13, 19:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6824/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/12/13, 19:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6918/ : SUCCESS -
Stefan Neufeind commented on patch set 3 04/12/13, 19:47
Looks good to me, but someone else must approve @Philipp: According to the code it's being called with GMENUs for the min/max-parameters. -
Christian Kuhn commented on patch set 3 1 comment 04/12/13, 19:47
I would prefer that you didn't submit this this is not as easy as it looks like: multiple methods of the contentObjectRenderer are called statically throughout the core, and they call each other. in this case here, calcIntExplode itself is called statically at other places, so this would raise at least a warning then. -
Stefan Neufeind commented on patch set 4 04/12/13, 19:47
Looks good to me, but someone else must approve Patch looks okay. There are some comments which could be fixed in the same go imho like: @see tslib_cObj::calc() -
Stefan Neufeind commented on patch set 4 04/12/13, 19:47
ContentObjectRenderer.php also has a static call to a non-static function for sanitizeSelectPart(). Maybe fix that as well? But then we should finally update the commit-msg - it's not just about one calc()-function anymore :-) -
Stefan Neufeind commented on patch set 4 04/12/13, 19:47
sanitizeSelectPart() in separate patch maybe? It's just one occurence though. -
Christian Kuhn uploaded patch set 4 04/12/13, 19:47
-
Christian Kuhn commented on patch set 4 04/12/13, 19:47
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 04/12/13, 19:47
how to test? -
Philipp Gampe commented on patch set 3 04/12/13, 19:47
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 04/12/13, 19:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6922/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/12/13, 19:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8367/ : SUCCESS -
Wouter Wolters uploaded patch set 3 04/12/13, 19:47
-
Wouter Wolters commented on patch set 3 04/12/13, 19:47
Fixed commit message -
Georg Ringer commented on patch set 4 V 0 04/12/13, 19:47
by team member; Looks good to me, approved -
Georg Ringer merged patch set 5 04/12/13, 19:47