Review main Merged

16783[BUGFIX] PHP strict warning in class loader

Christian Kuhn CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

The compatibility class loader overwrites method requireClassFileOnce
and adds a parameter. This triggers a PHP strict warning.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Ernesto Baschny +1
  • Verified V +2
    • Helmut Hummel +2
    • Ernesto Baschny +1

Issues 1

Files 1

Review log 5

  1. Ernesto Baschny commented on patch set 1 11/27/12, 10:06

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 11/27/12, 10:06

    This might be merged as late no-brainer. Let HH decide, please.
  3. Mr. Jenkins commented on patch set 1 11/27/12, 10:06

  4. Helmut Hummel commented on patch set 1 V 0 11/27/12, 10:06

    by team member; Looks good to me, approved
  5. Helmut Hummel merged patch set 1 11/27/12, 10:06