Review TYPO3_4-5 Merged

1680[BUGFIX] Wrong type hinting in interface tslib_menu_filterMenuPagesHook

Steffen Gebert CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 1

Review log 3

  1. Steffen Gebert commented on patch set 1 V 0 04/20/11, 07:51

    by team member; Looks good to me, approved Reviewed for master-branch in I0a61737755afbda6e2ab6c02ba59c078a77cc020
  2. Mr. Jenkins commented on patch set 1 04/20/11, 07:51

  3. Steffen Gebert merged patch set 1 04/20/11, 07:51