16824[BUGFIX] Deactivating "install" extension leads to exceptions
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Sebastian Michaelsen +1
- Oliver Klee +1
- Markus Klein +1
- Felix Kopp +1
-
Verified V +2
- Christian Kuhn +2
- Sebastian Michaelsen +1
- Markus Klein +1
- Felix Kopp +1
Files 1
Review log 14
-
Markus Klein commented on patch set 1 03/07/13, 22:53
Looks good to me, but someone else must approveBetter: Uninstalling the "install" extension leads to exceptions in required system extensions like extensionmanager or lang. The solution is to make "install" a required extension too. -
Markus Klein commented on patch set 1 03/07/13, 22:53
(1 inline comment) -
Stefan Neufeind commented on patch set 2 03/07/13, 22:53
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 2 03/07/13, 22:53
Verified; Looks good to me, but someone else must approve Improved commit message -
Markus Klein uploaded patch set 2 03/07/13, 22:53
-
Oliver Klee commented on patch set 2 03/07/13, 22:53
Looks good to me, but someone else must approve -
Sebastian Michaelsen commented on patch set 2 03/07/13, 22:53
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 2 03/07/13, 22:53
Verified; Looks good to me, but someone else must approve EXT: extensionmanager depends on EXT: install -
Felix Kopp commented on patch set 2 03/07/13, 22:53
I can not reproduce the underlying problem itself, sadly. What are the exceptions? -
Mr. Jenkins commented on patch set 1 03/07/13, 22:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6895/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/07/13, 22:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7009/ : SUCCESS -
Wouter Wolters commented on patch set 2 03/07/13, 22:53
Did you followed the instructions in Forge? -
Christian Kuhn commented on patch set 2 V 0 03/07/13, 22:53
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 03/07/13, 22:53