Review main Merged

16824[BUGFIX] Deactivating "install" extension leads to exceptions

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

Uninstalling the "install" extension leads to exceptions in
required system extensions like extensionmanager or lang.

The solution is to make "install" a required extension too.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Sebastian Michaelsen +1
    • Oliver Klee +1
    • Markus Klein +1
    • Felix Kopp +1
  • Verified V +2
    • Christian Kuhn +2
    • Sebastian Michaelsen +1
    • Markus Klein +1
    • Felix Kopp +1

Files 1

Review log 14

  1. Markus Klein commented on patch set 1 03/07/13, 22:53

    Looks good to me, but someone else must approve
    Better: Uninstalling the "install" extension leads to exceptions in required system extensions like extensionmanager or lang. The solution is to make "install" a required extension too.
  2. Markus Klein commented on patch set 1 03/07/13, 22:53

    (1 inline comment)
  3. Stefan Neufeind commented on patch set 2 03/07/13, 22:53

    Looks good to me, but someone else must approve
  4. Markus Klein commented on patch set 2 03/07/13, 22:53

    Verified; Looks good to me, but someone else must approve Improved commit message
  5. Markus Klein uploaded patch set 2 03/07/13, 22:53

  6. Oliver Klee commented on patch set 2 03/07/13, 22:53

    Looks good to me, but someone else must approve
  7. Sebastian Michaelsen commented on patch set 2 03/07/13, 22:53

    Verified; Looks good to me, but someone else must approve
  8. Felix Kopp commented on patch set 2 03/07/13, 22:53

    Verified; Looks good to me, but someone else must approve EXT: extensionmanager depends on EXT: install
  9. Felix Kopp commented on patch set 2 03/07/13, 22:53

    I can not reproduce the underlying problem itself, sadly. What are the exceptions?
  10. Mr. Jenkins commented on patch set 1 03/07/13, 22:53

  11. Mr. Jenkins commented on patch set 2 03/07/13, 22:53

  12. Wouter Wolters commented on patch set 2 03/07/13, 22:53

    Did you followed the instructions in Forge?
  13. Christian Kuhn commented on patch set 2 V 0 03/07/13, 22:53

    by team member; Looks good to me, approved
  14. Christian Kuhn merged patch set 3 03/07/13, 22:53