Review main Merged

16858[BUGFIX] ContentObjectRenderer instantiates old class names

Christian Kuhn CR +2 V +2 Normal +86 −16 updated 06/03/13, 20:49

Commit message

The content object renderer still instantiates content objects with
tslib_content_ prefix. The patch changes this to the namespaced
class. Additionally, all content objects are now tested for successful
instantiation with additional unit tests. While creating those tests
it became obvious that the ShockwaveFlashObject content object was
named incorrectly, so this is adapted along the way.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Helmut Hummel +1
    • Philipp Gampe +1

Files 7

Review log 8

  1. Christian Kuhn uploaded patch set 2 11/29/12, 19:18

  2. Helmut Hummel commented on patch set 3 11/29/12, 19:18

    Verified; Looks good to me, but someone else must approve
  3. Christian Kuhn commented on patch set 3 V 0 11/29/12, 19:18

    by team member; Looks good to me, approved
  4. Christian Kuhn uploaded patch set 3 11/29/12, 19:18

  5. Christian Kuhn merged patch set 3 11/29/12, 19:18

  6. Philipp Gampe commented on patch set 3 11/29/12, 19:18

    Verified; Looks good to me, but someone else must approve Tested with unit tests ... I do not have a flash object to test currenly.
  7. Mr. Jenkins commented on patch set 3 11/29/12, 19:18

  8. Philipp Gampe commented on patch set 3 11/29/12, 19:18

    Post review ... Videos are broken without the patch.