Review main Merged

16925[TASK] Provide a reason if set_no_cache() is called

Philipp Gampe CR +2 V +2 Easy +22 −16 updated 06/03/13, 20:49

Commit message

Since #20849, we can specify a reason why we call
GLOBALS['TSFE']->set_no_cache().

Provide a reason for all calls done in core.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Stefan Neufeind +1
  • Verified V +2
    • Dmitry Dulepov +2

Issues 2

Files 5

Review log 9

  1. Thorsten Kahler commented on patch set 2 12/07/12, 08:34

    (1 inline comment)
  2. Stefan Neufeind commented on patch set 2 12/07/12, 08:34

    Looks good to me, but someone else must approve Fine with me, useful, and technically imho almost a no-brainer. And I don't think we need to discuss the exact formulations of reasons (I personally think they are okay) since they are technical/internal only anyhow.

    TypoScriptFrontendController.php:315

    I agree. The only places in core that used this setting used it with lowercase. So if anything relied on the public-API it would have used the lowercase-variant for actually doing it's thing. (Yes, case-sensitivity counts.)
  3. Philipp Gampe uploaded patch set 2 12/07/12, 08:34

    TypoScriptFrontendController.php:315 Reply

    Thats how I found it :) I always call grep with "-Rin" which als shows those places PhpStorm does not know about.
  4. Philipp Gampe commented on patch set 2 12/07/12, 08:34

    I just changed the wording a little. Backport this patch to older branches? The information might be more useful than the backtrace which is logged by default. You need to set loglevel to at least warning in install tool to see those messages.
  5. Philipp Gampe commented on patch set 2 12/07/12, 08:34

    (1 inline comment)
  6. Mr. Jenkins commented on patch set 1 12/07/12, 08:34

  7. Mr. Jenkins commented on patch set 2 12/07/12, 08:34

  8. Dmitry Dulepov commented on patch set 2 V 0 12/07/12, 08:34

    by team member; Looks good to me, approved
  9. Dmitry Dulepov merged patch set 2 12/07/12, 08:34