17017[TASK] Remove function usage ctype_alnum in PageRenderer
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Files 2
Review log 11
-
Oliver Klee commented on patch set 1 01/28/13, 18:16
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 01/28/13, 18:16
I would prefer that you didn't submit this we should at least check if some test can be created for this method ...6.1, 6.0 -
Christian Kuhn commented on patch set 1 01/28/13, 18:16
unit test? -
Christian Kuhn uploaded patch set 2 01/28/13, 18:16
-
Christian Kuhn commented on patch set 2 01/28/13, 18:16
Ah, cool. The method already has 2 tests for the namespace test that is changed here. New patch set just changes the 'Releases' line of the commit message to include 6.1 and adds two non php-namespaced test annotations along the way. -
Dan Kleine - geb. Untenzu commented on patch set 1 01/28/13, 18:16
Looks good to me, but someone else must approve -
Dan Kleine - geb. Untenzu commented on patch set 1 01/28/13, 18:16
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/28/13, 18:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6984/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/28/13, 18:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7233/ : SUCCESS -
Christian Kuhn commented on patch set 2 V 0 01/28/13, 18:16
by team member; Looks good to me, approved merged as technical no-brainer, since it is also unit-test covered already. -
Christian Kuhn merged patch set 3 01/28/13, 18:16