Review main Merged

17020[TASK] Reduce severity for set_no_cache() from core

Philipp Gampe CR +2 V +2 Easy +19 −14 updated 06/03/13, 20:49

Commit message

Reduce the severity if an internal flag is set and the a backend user
is logged in.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2

Issues 2

Files 3

Review log 22

  1. Thorsten Kahler commented on patch set 2 04/24/13, 18:42

    I would prefer that you didn't submit this
    This is a new feature (API change) so it only applies to release 6.1 The API change should be mentioned in the commit message! (I'd prefer different commits for API change and usage of the new API but that's probably too much overhead in this case.)

    TypoScriptFrontendController.php:4416

    The severity levels should be switched.
  2. Philipp Gampe uploaded patch set 2 04/24/13, 18:42

    Reply

    The API is not changed (everything works as before), however fewer unsolvable warnings are produced. The flag is marked as internal, is optional and defaults to the old behavior and shall not be used by extensions. I think this is a bugfix, but I can understand if someone sees it different. In my understanding, a warning that is raised by normal software usage is a bug. You can not fix the warning, because the warned behavior is the intended behavior of the related code. E.g. if you are required to log all warnings and have some auto escalation/monitoring software, then a software that creates warning because of normal use, is just a mess. Do not produce warnings for legit internal calls.

    TypoScriptFrontendController.php:4416 Reply

    Done
  3. Philipp Gampe commented on patch set 2 04/24/13, 18:42

    (2 inline comments)
  4. Dmitry Dulepov commented on patch set 3 04/24/13, 18:42

    Looks good to me, approved
  5. Stefan Neufeind commented on patch set 3 04/24/13, 18:42

    Looks good to me, but someone else must approve simple approach, but imho okay for our current needs
  6. Georg Ringer commented on patch set 3 04/24/13, 18:42

    Verified; Looks good to me, approved
  7. Stefan Neufeind commented on patch set 4 04/24/13, 18:42

    Looks good to me, but someone else must approve Local test-environment seems broken. So I can only give a code-review for now.
  8. Markus Klein commented on patch set 4 04/24/13, 18:42

    Looks good to me, but someone else must approve
  9. Stefan Neufeind commented on patch set 5 04/24/13, 18:42

    Looks good to me, but someone else must approve
  10. Markus Klein commented on patch set 5 04/24/13, 18:42

    Looks good to me, but someone else must approve Fixed commit msg.
  11. Markus Klein uploaded patch set 5 04/24/13, 18:42

  12. Georg Ringer commented on patch set 4 04/24/13, 18:42

    works now with latest code
  13. Georg Ringer uploaded patch set 4 04/24/13, 18:42

  14. Philipp Gampe uploaded patch set 3 04/24/13, 18:42

  15. Philipp Gampe commented on patch set 4 04/24/13, 18:42

    You should vote, as this my patch.
  16. Mr. Jenkins commented on patch set 1 04/24/13, 18:42

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6985/ : FAILURE
  17. Mr. Jenkins commented on patch set 2 04/24/13, 18:42

  18. Mr. Jenkins commented on patch set 3 04/24/13, 18:42

  19. Mr. Jenkins commented on patch set 4 04/24/13, 18:42

  20. Mr. Jenkins commented on patch set 5 04/24/13, 18:42

  21. Jigal van Hemert commented on patch set 5 V 0 04/24/13, 18:42

    by team member; Looks good to me, approved Small change, works well. Won't backport to pre-6.0 because it's not a serious bug.
  22. Jigal van Hemert merged patch set 6 04/24/13, 18:42