17044[BUGFIX] Change localconf.php to LocalConfiguration.php
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
-
Verified V +2
- Steffen Ritter +2
Issues 1
Files 1
Review log 5
-
Mattias Nilsson commented on patch set 1 01/04/13, 12:18
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 1 01/04/13, 12:18
(1 inline comment) Adrian, See inline comment. Also you are creating this patches not on a clean master branch. This is what I do when pushing a patch Pull master branch Create branch git checkout -b [branchname] origin/master Make the changes and verify the fix Commit the patch and afterwards push it for review Then I do git checkout master. This is essential because otherwise you create dependecies for you're next patches. HTH To delete a branch git branch -D [branchname]6.1 is missing here -
Steffen Ritter commented on patch set 2 V 0 01/04/13, 12:18
by team member; Looks good to me, approved -
Wouter Wolters uploaded patch set 2 01/04/13, 12:18
-
Steffen Ritter merged patch set 3 01/04/13, 12:18