Review main Merged

1712[BUGFIX] pageNotFound_handling error with relative paths

Markus Klein CR +2 V +2 Easy +5 −1 updated 06/03/13, 20:49

Commit message

This patch fixes the handling of relative paths of pageNotFound_handling.
Due to a missing check, the relative path is prefixed with http_host only,
causing a wrong Location header.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Kurt Kunig +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Kurt Kunig +1

Issues 1

Files 1

Review log 14

  1. Markus Klein uploaded patch set 2 06/06/11, 14:29

  2. Markus Klein commented on patch set 2 06/06/11, 14:29

    @Kurt, you compared to the wrong branch. 4.5 has a different patch. And putting a '/' in front doesn't solve this issue for installations located in a subdirectory of a domain.
  3. Stefan Neufeind commented on patch set 3 06/06/11, 14:29

    Verified; Looks good to me, but someone else must approve
  4. Markus Klein uploaded patch set 3 06/06/11, 14:29

  5. Oliver Klee commented on patch set 2 06/06/11, 14:29

    (1 inline comment)

    class.tslib_fe.php:1524

    You can use $code{0} here. Please also use a strict check (===).
  6. Oliver Hader commented on patch set 1 06/06/11, 14:29

    Verified; Looks good to me, but someone else must approve
  7. Kurt Kunig commented on patch set 2 06/06/11, 14:29

    I would prefer that you didn't submit this TYPO3 V4.5.2: different code in line 1507 than in the patch!? statements starting in line 1505 = if ($code == t3lib_div::getIndpEnv('TYPO3_REQUEST_URL')) { if ($reason == '') { $reason = 'Page cannot be found.'; } $reason.= LF . LF . 'Additionally, ' . $code . ' was not found while trying to retrieve the error document.'; throw new RuntimeException('Reason: ' . nl2br(htmlspecialchars($reason))); } If you put a single "/" in front of the inserted error-page "/error404.html" instead of "error404.html" it works fine! Perhaps it would be simpler to change the description in the install-tool!?
  8. Kurt Kunig commented on patch set 2 06/06/11, 14:29

    Verified; Looks good to me, but someone else must approve
  9. Kurt Kunig commented on patch set 3 06/06/11, 14:29

    Verified; Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 06/06/11, 14:29

  11. Mr. Jenkins commented on patch set 2 06/06/11, 14:29

  12. Mr. Jenkins commented on patch set 3 06/06/11, 14:29

  13. Andreas Wolf commented on patch set 3 V 0 06/06/11, 14:29

    by team member; Looks good to me, approved
  14. Andreas Wolf merged patch set 3 06/06/11, 14:29