Review main Merged

17190[TASK] Fix phpDoc of BackendUtility::displayWarningMessages

Sebastian Michaelsen CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

phpDoc says "@return void" but the method returns the messages as
HTML string

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Alexander Schnitzler +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 2 12/18/12, 21:14

    Verified; Looks good to me, but someone else must approve no-brainer. Nothing really to "verify"
  2. Oliver Klee commented on patch set 2 12/18/12, 21:14

    Looks good to me, but someone else must approve
  3. Christian Kuhn commented on patch set 2 V 0 12/18/12, 21:14

    by team member; Looks good to me, approved
  4. Sebastian Michaelsen uploaded patch set 2 12/18/12, 21:14

  5. Anja Leichsenring commented on patch set 2 12/18/12, 21:14

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 12/18/12, 21:14

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7052/ : FAILURE
  7. Mr. Jenkins commented on patch set 2 12/18/12, 21:14

  8. Alexander Schnitzler commented on patch set 2 12/18/12, 21:14

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn merged patch set 3 12/18/12, 21:14