Review main Merged

17534[TASK] Use property injection in LanguageController

Sebastian Michaelsen CR +2 V +2 Easy +4 −40 updated 06/03/13, 20:49

Commit message

\TYPO3\CMS\Lang\Controller\LanguageController has 4
inject* Methods which a pretty vanilla and can be replaced
by property injection.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 7

  1. Christian Kuhn uploaded patch set 3 01/25/13, 22:22

  2. Christian Kuhn commented on patch set 3 V 0 01/25/13, 22:22

    by team member; Looks good to me, approved Obvious, thx. Also simple enough to merge in 6.0.
  3. Sebastian Michaelsen uploaded patch set 2 01/25/13, 22:22

  4. Mr. Jenkins commented on patch set 1 01/25/13, 22:22

  5. Mr. Jenkins commented on patch set 2 01/25/13, 22:22

  6. Mr. Jenkins commented on patch set 3 01/25/13, 22:22

  7. Christian Kuhn merged patch set 4 01/25/13, 22:22