Review main Merged

17540[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper

Sebastian Michaelsen CR +2 V +2 Normal +0 −149 updated 06/03/13, 20:49

Commit message

Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper this
is not used anymore in the core.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 15

  1. Christian Kuhn commented on patch set 2 02/01/13, 09:27

    I would prefer that you didn't submit this Please confirm: Imho this view helper is unused and should be removed completly. This was introduced in https://review.typo3.org/#/c/14293 and put out of use in https://review.typo3.org/#/c/14683/ if so, we should just remove this leftover completly (imho also ok for 6.0).
  2. Sebastian Michaelsen uploaded patch set 2 02/01/13, 09:27

  3. Mattias Nilsson commented on patch set 2 02/01/13, 09:27

    Looks good to me, but someone else must approve
  4. Anja Leichsenring commented on patch set 2 02/01/13, 09:27

    confirmed: no usage in Core
  5. Mr. Jenkins commented on patch set 1 02/01/13, 09:27

  6. Mr. Jenkins commented on patch set 2 02/01/13, 09:27

  7. Wouter Wolters commented on patch set 2 02/01/13, 09:27

    Looks good to me, but someone else must approve
  8. Wouter Wolters commented on patch set 2 02/01/13, 09:27

    I would prefer that you didn't submit this The only file that used the ViewHelper was typo3/sysext/lang/Resources/Private/Partials/LanguageSelectionList.html In the rebuild the reference to the ViewHelper was removed. So IMO it can be removed
  9. Oliver Klee commented on patch set 3 02/01/13, 09:27

    Looks good to me, but someone else must approve
  10. Anja Leichsenring commented on patch set 3 02/01/13, 09:27

    Verified; Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 3 02/01/13, 09:27

  12. Wouter Wolters uploaded patch set 3 02/01/13, 09:27

  13. Wouter Wolters commented on patch set 3 02/01/13, 09:27

    Verified; Looks good to me, but someone else must approve
  14. Christian Kuhn commented on patch set 3 V 0 02/01/13, 09:27

    by team member; Looks good to me, approved
  15. Christian Kuhn merged patch set 4 02/01/13, 09:27