17540[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
Issues 1
Files 1
Review log 15
-
Christian Kuhn commented on patch set 2 02/01/13, 09:27
I would prefer that you didn't submit this Please confirm: Imho this view helper is unused and should be removed completly. This was introduced in https://review.typo3.org/#/c/14293 and put out of use in https://review.typo3.org/#/c/14683/ if so, we should just remove this leftover completly (imho also ok for 6.0). -
Sebastian Michaelsen uploaded patch set 2 02/01/13, 09:27
-
Mattias Nilsson commented on patch set 2 02/01/13, 09:27
Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 2 02/01/13, 09:27
confirmed: no usage in Core -
Mr. Jenkins commented on patch set 1 02/01/13, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7170/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/01/13, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7171/ : SUCCESS -
Wouter Wolters commented on patch set 2 02/01/13, 09:27
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 2 02/01/13, 09:27
I would prefer that you didn't submit this The only file that used the ViewHelper was typo3/sysext/lang/Resources/Private/Partials/LanguageSelectionList.html In the rebuild the reference to the ViewHelper was removed. So IMO it can be removed -
Oliver Klee commented on patch set 3 02/01/13, 09:27
Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 3 02/01/13, 09:27
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 02/01/13, 09:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7278/ : SUCCESS -
Wouter Wolters uploaded patch set 3 02/01/13, 09:27
-
Wouter Wolters commented on patch set 3 02/01/13, 09:27
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 02/01/13, 09:27
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 4 02/01/13, 09:27