Review main Merged

17541[BUGFIX] Invalid RSA key when submitting form twice

Benni Mack CR +2 V +2 Easy +6 −4 updated 06/03/13, 20:49

Commit message

When submitting a RSA-supported form twice, the JS error
"Invalid RSA public key" is thrown. In order to suppress
this double RSA decryption, an additional JS check is needed.
The change also modifies the minified version of the JS
done with http://refresh-sf.com/yui/

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2
    • Dmitry Dulepov +1

Issues 1

Files 2

Review log 12

  1. Tolleiv Nietsch commented on patch set 1 02/16/13, 20:01

    Verified; Looks good to me, approved The check could have been done in a guard-clause to avoid too much nesting. But that's more my personal taste than any CGL.
  2. Tolleiv Nietsch uploaded patch set 2 02/16/13, 20:01

  3. Tolleiv Nietsch commented on patch set 2 02/16/13, 20:01

    I changed the patch and placed the actual change into a guard-clause. Makes it much cleaner and added 4.7 and 4.6 to the release list. Although I'm unsure whether including 4.6 is still right in any sense.
  4. Dmitry Dulepov commented on patch set 1 02/16/13, 20:01

    Looks good to me, approved
  5. Dmitry Dulepov commented on patch set 2 02/16/13, 20:01

    Verified; Looks good to me, approved
  6. Oliver Hader commented on patch set 1 1 comment 02/16/13, 20:01

    I would prefer that you didn't submit this What about fixing this in 4.6 and 4.7 as well? The releases annotation does not mention this...
  7. Helmut Hummel commented on patch set 2 V 0 02/16/13, 20:01

    by team member; Looks good to me, approved
  8. Mattias Nilsson commented on patch set 1 02/16/13, 20:01

    Looks good to me, but someone else must approve It look good, just one thing why 4.7 is missing as a release.
    Why not 4.7?
  9. Mr. Jenkins commented on patch set 1 02/16/13, 20:01

  10. Mr. Jenkins commented on patch set 2 02/16/13, 20:01

  11. Wouter Wolters commented on patch set 1 02/16/13, 20:01

    Looks good to me, but someone else must approve
  12. Helmut Hummel merged patch set 3 02/16/13, 20:01