17541[BUGFIX] Invalid RSA key when submitting form twice
Commit message
Review
-
Code review CR +2
- Dmitry Dulepov +2
- Helmut Hummel +2
-
Verified V +2
- Helmut Hummel +2
- Dmitry Dulepov +1
Issues 1
Files 2
Review log 12
-
Tolleiv Nietsch commented on patch set 1 02/16/13, 20:01
Verified; Looks good to me, approved The check could have been done in a guard-clause to avoid too much nesting. But that's more my personal taste than any CGL. -
Tolleiv Nietsch uploaded patch set 2 02/16/13, 20:01
-
Tolleiv Nietsch commented on patch set 2 02/16/13, 20:01
I changed the patch and placed the actual change into a guard-clause. Makes it much cleaner and added 4.7 and 4.6 to the release list. Although I'm unsure whether including 4.6 is still right in any sense. -
Dmitry Dulepov commented on patch set 1 02/16/13, 20:01
Looks good to me, approved -
Dmitry Dulepov commented on patch set 2 02/16/13, 20:01
Verified; Looks good to me, approved -
Oliver Hader commented on patch set 1 1 comment 02/16/13, 20:01
I would prefer that you didn't submit this What about fixing this in 4.6 and 4.7 as well? The releases annotation does not mention this... -
Helmut Hummel commented on patch set 2 V 0 02/16/13, 20:01
by team member; Looks good to me, approved -
Mattias Nilsson commented on patch set 1 02/16/13, 20:01
Looks good to me, but someone else must approve It look good, just one thing why 4.7 is missing as a release.Why not 4.7? -
Mr. Jenkins commented on patch set 1 02/16/13, 20:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7173/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/16/13, 20:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7349/ : SUCCESS -
Wouter Wolters commented on patch set 1 02/16/13, 20:01
Looks good to me, but someone else must approve -
Helmut Hummel merged patch set 3 02/16/13, 20:01