Review main Merged

17543[BUGFIX] displayWarningMessages uses wrong returnUrl

Sebastian Michaelsen CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The warning in the "About Modules" module about an
insecure admin offers a link to edit this user. Following
this link and then closing the form again leads to a 404.
The reason is a wrong returnUrl in
BackendUtility:: displayWarningMessages.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Mattias Nilsson +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 11

  1. Sebastian Michaelsen uploaded patch set 2 01/30/13, 20:05

    BackendUtility.php:3861

    one could also use $_GET['M'] here to make it independent from the "about modules" module, but I was not sure about security. It should be save after passing through urlencode and htmlspecialchars (1 line below), right?
  2. Sebastian Michaelsen commented on patch set 2 01/30/13, 20:05

    (1 inline comment)
  3. Christian Kuhn commented on patch set 3 01/30/13, 20:05

    looking at the whole thing, the method itself should be merged to ext:aboutmodules (it is the only one showing it), and be deprecated. furthermore, ext:reports tends to 'overlay' other warnings. i'm still thinking about a strategy here ... eg. showing a default admin user password warning should be done in ext:reports only, similar to other warnings. and ... well ... imho it is not done, if we just fix this small issue.
  4. Sebastian Michaelsen uploaded patch set 3 01/30/13, 20:05

  5. Mattias Nilsson commented on patch set 3 01/30/13, 20:05

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 01/30/13, 20:05

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7174/ : FAILURE
  7. Mr. Jenkins commented on patch set 2 01/30/13, 20:05

  8. Mr. Jenkins commented on patch set 3 01/30/13, 20:05

  9. Wouter Wolters commented on patch set 3 01/30/13, 20:05

    Looks good to me, but someone else must approve
  10. Christian Kuhn commented on patch set 3 V 0 01/30/13, 20:05

    by team member; Looks good to me, approved +1 on reading and testing. ok, merging this one for now to get rid of the issue. for 6.1, the whole method should be gone in a b/w compatible way somehow.
  11. Christian Kuhn merged patch set 4 01/30/13, 20:05