17543[BUGFIX] displayWarningMessages uses wrong returnUrl
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Mattias Nilsson +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 1
Review log 11
-
Sebastian Michaelsen uploaded patch set 2 01/30/13, 20:05
-
Sebastian Michaelsen commented on patch set 2 01/30/13, 20:05
(1 inline comment) -
Christian Kuhn commented on patch set 3 01/30/13, 20:05
looking at the whole thing, the method itself should be merged to ext:aboutmodules (it is the only one showing it), and be deprecated. furthermore, ext:reports tends to 'overlay' other warnings. i'm still thinking about a strategy here ... eg. showing a default admin user password warning should be done in ext:reports only, similar to other warnings. and ... well ... imho it is not done, if we just fix this small issue. -
Sebastian Michaelsen uploaded patch set 3 01/30/13, 20:05
-
Mattias Nilsson commented on patch set 3 01/30/13, 20:05
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/30/13, 20:05
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7174/ : FAILURE -
Mr. Jenkins commented on patch set 2 01/30/13, 20:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7175/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/30/13, 20:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7208/ : SUCCESS -
Wouter Wolters commented on patch set 3 01/30/13, 20:05
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 01/30/13, 20:05
by team member; Looks good to me, approved +1 on reading and testing. ok, merging this one for now to get rid of the issue. for 6.1, the whole method should be gone in a b/w compatible way somehow. -
Christian Kuhn merged patch set 4 01/30/13, 20:05
BackendUtility.php:3861