17571[FEATURE] Introduce service to handle multiple flash message queues
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Neufeind +1
- Andreas Wolf +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 4
Review log 47
Show 22 earlier messages
-
Mattias Nilsson commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit thisFlashMessageQueue.php:174missing @return void -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7180/ : SUCCESS -
Peter Niederlag commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve nice improvement! -
Andreas Wolf commented on patch set 2 05/27/13, 17:19
Tested only the unit tests, did not construct some example application - but I think Alex will supply a test extension. -
Andreas Wolf commented on patch set 2 05/27/13, 17:19
(3 inline comments) Replied to Alex' comments. -
Andreas Wolf commented on patch set 2 6 comments 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve All in all this looks good, commented on some small issues. -
Sebastian Michaelsen commented on patch set 2 05/27/13, 17:19
(1 inline comment) -
Jigal van Hemert commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve Please provide a means (example ext) to see it in action. -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7181/ : SUCCESS -
Alexander Schnitzler commented on patch set 2 05/27/13, 17:19
Because I was told that there shouldn't be new static methods as they cannot be unit tested very well. Alos it's called a service and therefore its expected to be instantiated.FlashMessageQueue.php:63ReplyYou mean "storeFlashMessagesInSession"? Can you please explain via im later?FlashMessageQueue.php:71ReplyThe problem here is that you can only dequeue local flash messages and not the ones in the session whereas enqueue differentiates the flash message type. Also there is no need (yet) to dequeue something. But I am open to change this.FlashMessageQueue.php:193There are circumstances under which even an empty queue can be considered valid, so I changed the behaviour here to check for the queue not to be valid but not to be empty.FlashMessageQueue.php:194@Stefan Neufeind: Ich checked this one again. dequeue runs next internally, so I removed it.FlashMessageQueue.php:195ReplyYes, you're right. Dequeue should call next in the background.FlashMessageQueue.php:204Replyenqueue hasn't been part of the old api as this class didn't inherit SplQueue before.FlashMessageQueue.php:234ReplyWhich one exactly? Some "method not found" Exception?FlashMessageQueue.php:235@Helmut: I hope you are fine with it. As this Exception only occurs if a user misuses the method I considered it to be a RuntimeException.FlashMessageQueue.php:236ReplyI dont't think so as these methods will exist natively in 6.3 as soon as the method names are "free" again and therefore they are not deprecated at all imo.FlashMessageQueueTest.php:47ReplyHave to rebase for this as this typo has also been in the class name itself. -
Alexander Schnitzler commented on patch set 2 05/27/13, 17:19
Added some missing comments, the "@return void" and the DeprecationLog call. -
Alexander Schnitzler commented on patch set 2 05/27/13, 17:19
(3 inline comments) -
Alexander Schnitzler uploaded patch set 2 05/27/13, 17:19
-
Andreas Wolf commented on patch set 3 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Andreas Wolf commented on patch set 4 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve Fixed a failing unit test (because of wrong class name). -
Andreas Wolf uploaded patch set 4 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
(4 inline comments) -
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
(3 inline comments) -
Helmut Hummel commented on patch set 4 05/27/13, 17:19
(2 inline comments) -
Christian Kuhn commented on patch set 4 05/27/13, 17:19
up. a extbase patch for this is also pending. -
Anja Leichsenring commented on patch set 4 05/27/13, 17:19
some comments are still not solved. the pending extbase patch serves as replacement in case this one gets not merged. -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7422/ : SUCCESS
-
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7430/ : SUCCESS -
Alexander Schnitzler uploaded patch set 3 05/27/13, 17:19
-
Alexander Schnitzler commented on patch set 3 05/27/13, 17:19
An extension for testing this feature can be found here: https://github.com/alexanderschnitzler/Flashmessages -
Alexander Schnitzler commented on patch set 4 05/27/13, 17:19
(1 inline comment) -
Alexander Schnitzler commented on patch set 4 05/27/13, 17:19
(3 inline comments) -
Alexander Schnitzler commented on patch set 4 05/27/13, 17:19
Rebased -
Mr. Jenkins commented on patch set 5 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7738/ : SUCCESS -
Andreas Wolf commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve Did not test it again, but there are only minor changes since my review. I only have some small nitpicks documentation-wise and regarding the exceptions used, that should not really stop us from merging this. -
Stefan Neufeind commented on patch set 7 05/27/13, 17:19
Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 7 05/27/13, 17:19
-
Christian Kuhn commented on patch set 7 V 0 05/27/13, 17:19
by team member; Looks good to me, approved -
Christian Kuhn commented on patch set 7 V 0 05/27/13, 17:19
This looks good, imho. One thing that blocks me from merging is that I don't want to merge new deprecations (for the old methods) if they are still in use in the core .... So: We can get this in, if it is definatly taken care that the deprecations are fixed quickly (!) after this one here is in. Anyone want to sign this and take care? -
Christian Kuhn merged patch set 8 05/27/13, 17:19
-
Anja Leichsenring commented on patch set 7 05/27/13, 17:19
afaik Wouter is already on this. -
Anja Leichsenring commented on patch set 7 05/27/13, 17:19
https://review.typo3.org/#/c/19225/ is the follow up ticket -
Mr. Jenkins commented on patch set 6 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7742/ : SUCCESS -
Mr. Jenkins commented on patch set 7 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7901/ : SUCCESS -
Alexander Schnitzler uploaded patch set 6 05/27/13, 17:19
-
Alexander Schnitzler commented on patch set 6 05/27/13, 17:19
(3 inline comments) -
Alexander Schnitzler commented on patch set 7 05/27/13, 17:19
@Christian: I could provide such a patch. But next week at the earliest. Currently I am on vacation, so what about declaring the needed changes to be bugfixes and I will take care of them asap? -
Wouter Wolters commented on patch set 6 05/27/13, 17:19
Looks good to me, but someone else must approveFlashMessageQueue.php:214As discussed it would be better if we set: @deprecated since 6.1 will be removed in two versions This is for all deprecations in this file -
Wouter Wolters commented on patch set 7 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve And for workspaces: https://review.typo3.org/19227 -
Markus Klein commented on patch set 8 10/02/13, 20:30
Did you remove the addMessage method on purpose back then?? -
Markus Klein commented on patch set 8 10/02/13, 20:57
Sorry, no breaking change. But insufficient deprecation. No log message, therefore no removal of this code. -
Alexander Schnitzler commented on patch set 8 10/02/13, 21:10
As explained in the patchset you just provided it's not a real deprecation. It has to be removed but the actual methods need to stay implemented.