17588[BUGFIX] StorageRepository must respect 'deleted' flag
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 15
-
Christian Kuhn uploaded patch set 3 02/01/13, 14:02
-
Sebastian Michaelsen uploaded patch set 2 02/01/13, 14:02
-
Sebastian Michaelsen commented on patch set 2 02/01/13, 14:02
(1 inline comment) -
Stefan Froemken commented on patch set 1 02/01/13, 14:02
Verified; Looks good to me, but someone else must approveStorageRepository.php:209It works but maybe it is better to solve this with two lines and not one long row -
Stefan Froemken commented on patch set 1 02/01/13, 14:02
(1 inline comment) -
Stefan Froemken commented on patch set 2 02/01/13, 14:02
Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 2 02/01/13, 14:02
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 02/01/13, 14:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7182/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/01/13, 14:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7199/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/01/13, 14:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7286/ : SUCCESS -
Alexander Schnitzler commented on patch set 2 02/01/13, 14:02
I would prefer that you didn't submit thisStorageRepository.php:207Changing this please initialize $whereClause first. I know PHP allows you to do this, but it's not clean.StorageRepository.php:207ReplySorry, I saw it wrong. Thought you would replace line 206 with 207 which wouldn't make sense. -
Alexander Schnitzler commented on patch set 2 1 comment 02/01/13, 14:02
No score -
Wouter Wolters commented on patch set 2 02/01/13, 14:02
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 3 V 0 02/01/13, 14:02
by team member; Looks good to me, approved added a test, so this bug does not show his ugly face again ... no change in the code itself, will merge now, taking the votes of the sets before into account. -
Christian Kuhn merged patch set 4 02/01/13, 14:02