Review main Merged

17588[BUGFIX] StorageRepository must respect 'deleted' flag

Sebastian Michaelsen CR +2 V +2 Normal +74 −0 updated 06/03/13, 20:49

Commit message

The FAL's Storage Repository find* methods also load
deleted file storages at the moment.

Reproduce:
* Create some "File Storage" records on the root page and
delete some of them
* Open the File module, it will showdeleted File Storages

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 15

  1. Christian Kuhn uploaded patch set 3 02/01/13, 14:02

  2. Sebastian Michaelsen uploaded patch set 2 02/01/13, 14:02

  3. Sebastian Michaelsen commented on patch set 2 02/01/13, 14:02

    (1 inline comment)
  4. Stefan Froemken commented on patch set 1 02/01/13, 14:02

    Verified; Looks good to me, but someone else must approve

    StorageRepository.php:209

    It works but maybe it is better to solve this with two lines and not one long row
  5. Stefan Froemken commented on patch set 1 02/01/13, 14:02

    (1 inline comment)
  6. Stefan Froemken commented on patch set 2 02/01/13, 14:02

    Looks good to me, but someone else must approve
  7. Mattias Nilsson commented on patch set 2 02/01/13, 14:02

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 02/01/13, 14:02

  9. Mr. Jenkins commented on patch set 2 02/01/13, 14:02

  10. Mr. Jenkins commented on patch set 3 02/01/13, 14:02

  11. Alexander Schnitzler commented on patch set 2 02/01/13, 14:02

    I would prefer that you didn't submit this

    StorageRepository.php:207

    Changing this please initialize $whereClause first. I know PHP allows you to do this, but it's not clean.

    StorageRepository.php:207 Reply

    Sorry, I saw it wrong. Thought you would replace line 206 with 207 which wouldn't make sense.
  12. Alexander Schnitzler commented on patch set 2 1 comment 02/01/13, 14:02

    No score
  13. Wouter Wolters commented on patch set 2 02/01/13, 14:02

    Looks good to me, but someone else must approve
  14. Christian Kuhn commented on patch set 3 V 0 02/01/13, 14:02

    by team member; Looks good to me, approved added a test, so this bug does not show his ugly face again ... no change in the code itself, will merge now, taking the votes of the sets before into account.
  15. Christian Kuhn merged patch set 4 02/01/13, 14:02