Review main Merged

17590[TASK] Add save only button to Scheduler task

Lorenz Ulrich CR +2 V +2 Easy +20 −7 updated 06/03/13, 20:49

Commit message

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Review

  • Code review CR +2
    • Francois Suter +2
    • Lorenz Ulrich +1
    • Ingo Renner +1
    • Christopher Seidel +1
  • Verified V +2
    • Francois Suter +2
    • Lorenz Ulrich +1
    • Ingo Renner +1
    • Christopher Seidel +1

Files 2

Review log 17

  1. Ingo Renner commented on patch set 1 01/23/13, 20:01

    Fails Does not work yet for the situation where you add a task and save it. The task does not have additional fields loaded the same way they have been set when creating it.
  2. Ingo Renner uploaded patch set 2 01/23/13, 20:01

  3. Ingo Renner commented on patch set 2 01/23/13, 20:01

    Verified; Looks good to me, but someone else must approve Now also works for editing a just created task :)
  4. Ingo Renner uploaded patch set 3 01/23/13, 20:01

  5. Ingo Renner commented on patch set 3 01/23/13, 20:01

    Verified; Looks good to me, but someone else must approve Fixed Mr. Jenkins' CGL complaint ;)
  6. Lorenz Ulrich uploaded patch set 4 01/23/13, 20:01

  7. Ingo Renner commented on patch set 5 01/23/13, 20:01

    Verified; Looks good to me, but someone else must approve
  8. Lorenz Ulrich commented on patch set 5 01/23/13, 20:01

    Verified; Looks good to me, but someone else must approve I only removed the indentation of the comments because we don't ident anymore since 6.0.
  9. Lorenz Ulrich uploaded patch set 5 01/23/13, 20:01

  10. Christopher Seidel commented on patch set 5 01/23/13, 20:01

    Verified; Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 01/23/13, 20:01

  12. Mr. Jenkins commented on patch set 2 01/23/13, 20:01

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7191/ : FAILURE
  13. Mr. Jenkins commented on patch set 3 01/23/13, 20:01

  14. Mr. Jenkins commented on patch set 4 01/23/13, 20:01

  15. Mr. Jenkins commented on patch set 5 01/23/13, 20:01

  16. Francois Suter commented on patch set 5 V 0 01/23/13, 20:01

    by team member; Looks good to me, approved Works fine. I let you take care of the backporting.
  17. Francois Suter merged patch set 6 01/23/13, 20:01