Review main Merged

17670[TASK] Cleanups for sysext belog

Sebastian Michaelsen CR +2 V +2 Easy +10 −36 updated 06/03/13, 20:49

Commit message

* Fix references to old classes
* Use property injection where possible

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 5

Review log 8

  1. Christian Kuhn uploaded patch set 3 01/25/13, 21:24

  2. Sebastian Michaelsen uploaded patch set 2 01/25/13, 21:24

  3. Mr. Jenkins commented on patch set 1 01/25/13, 21:24

  4. Mr. Jenkins commented on patch set 2 01/25/13, 21:24

  5. Mr. Jenkins commented on patch set 3 01/25/13, 21:24

  6. Wouter Wolters commented on patch set 1 01/25/13, 21:24

    Looks good to me, but someone else must approve

    AbstractController.php:86

    IMHO @throws is placed after @return annotation
  7. Christian Kuhn commented on patch set 3 V 0 01/25/13, 21:24

    by team member; Looks good to me, approved Thx, nice cleanup! Patch is obvious. I just pushed a new patch set to have this in 6.0 as well.
  8. Christian Kuhn merged patch set 4 01/25/13, 21:24