17670[TASK] Cleanups for sysext belog
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 5
- typo3/sysext/belog/Classes/Controller/AbstractController.php1+4 −12
- typo3/sysext/belog/Classes/ViewHelpers/Be/AddJsFileViewHelper.php+2 −2
- typo3/sysext/belog/Classes/ViewHelpers/Be/InlineSettingsArrayViewHelper.php+2 −2
- typo3/sysext/belog/Classes/ViewHelpers/HistoryEntryViewHelper.php+1 −10
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+1 −10
Review log 8
-
Christian Kuhn uploaded patch set 3 01/25/13, 21:24
-
Sebastian Michaelsen uploaded patch set 2 01/25/13, 21:24
-
Mr. Jenkins commented on patch set 1 01/25/13, 21:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7200/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/25/13, 21:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7207/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/25/13, 21:24
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7213/ : SUCCESS -
Wouter Wolters commented on patch set 1 01/25/13, 21:24
Looks good to me, but someone else must approveAbstractController.php:86IMHO @throws is placed after @return annotation -
Christian Kuhn commented on patch set 3 V 0 01/25/13, 21:24
by team member; Looks good to me, approved Thx, nice cleanup! Patch is obvious. I just pushed a new patch set to have this in 6.0 as well. -
Christian Kuhn merged patch set 4 01/25/13, 21:24