Review TYPO3_4-7 Merged

17682[TASK] Add save only button to Scheduler task

Christian Kuhn CR +2 V +2 Easy +20 −12 updated 06/03/13, 20:49

Commit message

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 2

Review log 3

  1. Christian Kuhn commented on patch set 1 V 0 05/07/13, 21:37

    by team member; Looks good to me, approved
  2. Christian Kuhn merged patch set 2 05/07/13, 21:37

  3. Thorsten Kahler commented on patch set 2 05/07/13, 21:37

    (1 inline comment) Backport failed: $this->submittedData['uid'] is set after updating, not saving, of task

    class.tx_scheduler_module.php:1280

    msg.updateError -> wrong place for patch hunk