Review main Merged

17776[TASK] EXT:reports Improve xclass reporting

Christian Kuhn CR +2 V +2 Normal +161 −5 updated 06/03/13, 20:49

Commit message

Since TYPO3 CMS 6.0, the XCLASS registration changed and the old
registration style does not work anymore. Additionally, 6.0 comes
with a basic check for old XCLASS registration to warn users about
that.

The patch adds a new report for newly registered XCLASS'es and
adapts the messages to better notify that neither old nor new
registrations are a real problem, but that those classes should
be kept an eye on during upgrading.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 9

  1. Christian Kuhn uploaded patch set 2 01/29/13, 08:00

    Typo3Status.php:119

    ">" is missing ...
  2. Christian Kuhn uploaded patch set 3 01/29/13, 08:00

  3. Jigal van Hemert commented on patch set 3 V 0 01/29/13, 08:00

    by team member; Looks good to me, approved Works correct with old and new registered XCLASSes.
  4. Jigal van Hemert merged patch set 4 01/29/13, 08:00

  5. Mr. Jenkins commented on patch set 1 01/29/13, 08:00

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7239/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 01/29/13, 08:00

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7240/ : FAILURE
  7. Mr. Jenkins commented on patch set 3 01/29/13, 08:00

  8. Wouter Wolters commented on patch set 3 01/29/13, 08:00

    Verified; Looks good to me, but someone else must approve
  9. Christian Kuhn commented on patch set 4 01/29/13, 08:00

    (1 inline comment) i'll send a small follow up to fix html (see comment), and will then backport the thing to 6.0