Review main Merged

17834[TASK] Cleanups for CSS Styled Content

Sebastian Michaelsen CR +2 V +2 Easy +0 −20 updated 06/03/13, 20:49

Commit message

* Remove "@todo Define visibility" annotations from the render_*
methods. They are called from TS, they need to be public.
* Remove unused variables from the CssStyledContentController
* Don't pass the constants borderColor and rowSpace to
tt_content.image any more, they are not used there

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 8

  1. Mr. Jenkins commented on patch set 1 02/01/13, 15:51

  2. Christian Kuhn commented on patch set 2 02/01/13, 15:51

    I would prefer that you didn't submit this I'm against removing the @todo: define visibility annotation per-se. we should talk about the procedure at this point in the core list.
  3. Christian Kuhn commented on patch set 2 02/01/13, 15:51

    Verified; Looks good to me, but someone else must approve Sebastian asked me to reconsider my this change, so here we go: the render_* methods must indeed be public, the php vars are not used, and the TS change is also ok. +1 on reading and testing.
  4. Mr. Jenkins commented on patch set 2 02/01/13, 15:51

  5. Wouter Wolters commented on patch set 2 02/01/13, 15:51

    Looks good to me, but someone else must approve Testing will be done tomorrow if not merged already.
  6. Wouter Wolters uploaded patch set 2 02/01/13, 15:51

  7. Christian Kuhn commented on patch set 2 V 0 02/01/13, 15:51

    by team member; Looks good to me, approved Think I'll just merge it, its pretty obvious anyway.
  8. Christian Kuhn merged patch set 3 02/01/13, 15:51